Currently making changes to the generator is very time consuming and even tough it is great having multiple options, the users of the generator only use the starter variant.
The demo variation is also used on a demo website, but the approach on how this demo theme is built should be revised, probably by leveraging the css variables, something for a later date.
Existing structure:
BASE → MINIMAL
BASE → MINIMAL → STARTER
BASE → MINIMAL → STARTER → FLEX
BASE → MINIMAL → STARTER → FLEX → DEMO
Simplify the structure to have only STARTER
The way this would be accomplished is quite straight forward:
* Move and overwrite STARTER files on top of MINIMAL
* Move and overwrite MINIMAL files on top of BASE
* Rename BASE to STARTER
* Move and overwrite DEMO on top of FLEX
* Rename FLEX to demo
* Move any features from DEMO that are relevant to keep into STARTER
* Clean up /scripts/generate-theme.php to remove the options for minimal, flex and demo
* Update the rocketship d.o page to remove the options for minimal, flex and demo
This change will provide us with a simpler code base that will allow us a faster iteration and evolution of the rocketship theme.
This could justify a version 4.x of the theme
This is a major change, so any other ongoing work will need to be adjusted once this change is in place
Fixed
4.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
After internal discussion we decided to remove the demo theme from the generator.
Merged this work since it will simplify much of the upcoming work
Automatically closed - issue fixed for 2 weeks with no activity.