> the selectors for the button styles are overly complicated
Completely agree that the buttons are overcomplicated and need to be simplified! It happened as a result of retroactive base style changes followed up by revised button designs. We've been wanting to fix it, but when we learned there was likely more of each coming, we paused on it so we didn't end up redoing it multiple more times.
This quick fix works for me!
One thing to note, for the Get Started Menu link, since it's a button looking parent link of a drop down that currently only ever exposes the menu on hover, you never see its active state in the wild unless you do weird stuff with the cursor on the button. Unrelated to this MR, but worth mentioning so it stays in my head, we might want that menu to be click open like the mega menu panels, in which case there would be an active state for it.
Looks good to me! I can approve but not merge on the private repo.
This looks good to me! I did a before and after and confirm the reduction in load resource demand. I also watched the video and it definitely seems to confirm that latin alone seems sufficient. The primary differences seems to be the letter spacing, as noted, and the fallback seems more condensed vertically. It's hard to notice the difference based on the examples. It is possible there could be a use case where e.g. Hindi and English appear together on the same page inline, and if the former is in helvetica and the latter in notosans that you might see a small aberration in the character height when it transitions from one to the other. I tried to test this by loading up the test case locally, but for some reason I was getting the same rendered fonts on both pages so can't confirm. For example, Thai is being rendered as Thonburi on the Latin page.
(Screenshot attached)
spicy.werewolf → created an issue.
Don't merge this until its counterpart MRs are merged.
Parent ticket: https://gitlab.com/drupal-infrastructure/sites/drupalorg/-/issues/43
Bluecheese: https://git.drupalcode.org/project/bluecheese/-/merge_requests/167#2e780...
drupalorg project: https://gitlab.com/drupal-infrastructure/sites/drupalorg/-/merge_request...
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
Testing steps are in the parent task in the drupalorg project repo: https://gitlab.com/drupal-infrastructure/sites/drupalorg/-/issues/99
spicy.werewolf → created an issue.
fjgarlin → credited spicy.werewolf → .
spicy.werewolf → made their first commit to this issue’s fork.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → made their first commit to this issue’s fork.
fjgarlin → credited spicy.werewolf → .
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → made their first commit to this issue’s fork.
spicy.werewolf → created an issue.
fjgarlin → credited spicy.werewolf → .
spicy.werewolf → created an issue.
spicy.werewolf → made their first commit to this issue’s fork.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → made their first commit to this issue’s fork.
It's impossible for me to implement the changes I need to make to button styles for the CTAs without a systematic treatment of cta link and button styles, so I am expanding the scope of this issue to include those here as well.
spicy.werewolf → made their first commit to this issue’s fork.
spicy.werewolf → created an issue.
All the component theme work is done, but I am keeping this open until the corresponding config is merged into the drupalorg project.
spicy.werewolf → made their first commit to this issue’s fork.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.
spicy.werewolf → created an issue.