Patch attached
porchlight → created an issue.
Yeah something like that might help people track down the issue at least if they start seeing strange behaviours.
Yeah, we were already using the 'ext' class for something else, not related to external links. We were only using extlink module to open external links in new a tab and add the title attribute to links, but no icon, so it wasn't adding the 'ext' class to all the links. Now with the latest update it is, which is then applying all our "ext" styles to the links, making things look really broken.
Anyways I have fixed our sites by changing our custom templates and css to use a different class name than 'ext'. But this could still throw other people for a loop, maybe its not something that needs to be "fixed" and just something people should be aware of if by chance they were using the module the same way we were AND they had styling attached to an unrelated "ext" class... When I say it out loud it sounds like a real unlikely coincidence. Probably can Close (works as designed)
porchlight → created an issue.
@Berdir Thank you! After you said that I looked around some more and found this in the token_filter settings form.
porchlight → created an issue.
porchlight → created an issue.
Yes! Sorry, I guess I should have stated that.
Tested the templates provided by https://www.drupal.org/project/ckeditor5_plugin_pack → and they have the same issue...
The diff changes were made on the 2.x branch including their 2.0.0-beta1 release.
porchlight → created an issue.
2.0.x patch
porchlight → created an issue.
porchlight → created an issue.
The latest release of diff module has also added some type hinting to the`PluginRevisionController` class which `ConfigEntityRevisionsDiffController` extends. Here is a patch to fix the type hinting. The diff module also marked the construct method as final which breaks this as well. I have created a patch on their module to revert that here - https://www.drupal.org/project/diff/issues/3460554 🐛 Fatal error: Cannot override final method Drupal\diff\Controller\PluginRevisionController::__construct() Active
Patch to remove final
porchlight → created an issue.
Stopped working in 10.3 -- Re-roll of #85
@dbielke1986 that's totally fair. I figured it wasn't something we could solve in this module but was hoping maybe somebody had some trick to get around it. Anyways, all good. I'll monitor the other issues for a fix. I also noticed the ckeditor plugin pack https://www.drupal.org/project/ckeditor5_plugin_pack → has templates that may work, but not available until Drupal 10.3, so worse comes to worst I can wait for that. You can play with the templates on the ckeditor demo page https://ckeditor.com/docs/ckeditor5/latest/features/template.html - it looks like they incorporate widget functionality somehow.
@dbielke1986 Nice! Thanks for the suggestion! That kinda solves it, but I think it creates other issues?
- it prints an empty
<p>tag in the textarea on the front-end page. - if you move your cursor to that
<p>tag and then hit backspace, you erase that<p>tag and then you can get stuck in the template again - doesn't take into account textareas that already exist using these templates. If a textarea ends in one of these templates currently without the
<p>then you still cannot get below the template.
Not trying to take it out on you! I know it's a ckeditor issue and I appreciate the suggestion; I just don't think that's going to be enough to appease my end-users.
porchlight → created an issue.
porchlight → made their first commit to this issue’s fork.
There is another call to trim() which may contain an empty value a few lines down. This patch covers that and is also for 2.0.0-beta4
re-roll for 1.5
@memtkmcc AMAZING! Looking forward to it! Thanks for the quick reply
Hey @memtkmcc glad you got it figured out! Would you mind sharing what would work for those of us not on the BOA stack? I tried installing the BOA drush 8 fork and using your D10 patch posted on your github, but I must be missing something still as my site install task still contains errors. Are you installing drush 11/12 on the site level? Any help or direction would be greatly appreciated. Thanks for all your efforts!
@vensires Feel free to take it over! I did this a long time ago and don't have a need for this module anymore. We can close this issue if it's confusing.
I'm still experiencing the comma in the From name issue on 6.2.0-rc1 - Drupal 9.5.11
Same steps to reproduce as in the initial issue description.
Anybody by chance have Aegir 3 working with Drupal 10? We were able to get Drupal 9, but I've tried to apply some of the above solutions to Drupal 10 and not having any luck.
Quick and dirty patch for 2.0.1
After applying the changes in the current merge request I'm getting an error when I run cron. Need to add `$query->accessCheck(TRUE);` to the hook_cron function in the .module. I would do it but I don't know how to add to the MR.
Patch
porchlight → created an issue.
Thanks @omkar_yewale !