- Issue created by @welly
- Merge request !15Providing default value for trim function call using coalescing operator → (Closed) created by welly
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
about 1 year ago Waiting for branch to pass - Status changed to Needs review
about 1 year ago 3:35pm 7 November 2023 - Assigned to siddhant.bhosale
- 🇮🇳India chetan 11
chetan 11 → made their first commit to this issue’s fork.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
about 1 year ago Waiting for branch to pass - Issue was unassigned.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
12 months ago Waiting for branch to pass - 🇬🇧United Kingdom Finn Lewis
The merge request here is against the dev branch, 2.0.x, which makes sense.
We're still using the latest tagged release, which seems to be 2.0.0-beta4.
Here's a patch against oauth2_server 2.0.0-beta4.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
11 months ago Waiting for branch to pass - 🇨🇦Canada porchlight
There is another call to trim() which may contain an empty value a few lines down. This patch covers that and is also for 2.0.0-beta4
- 🇺🇸United States jghyde
Tested with php 8.1.7 and it works.
Curious why you didn't use trim((string) $var) instead? https://stackoverflow.com/questions/71707325/migration-to-php-8-1-how-to...
- Status changed to Needs work
11 months ago 9:47pm 7 March 2024 - 🇦🇺Australia cafuego
I've merged a large Drupal 10 compat patch set and this patch either needs a refactor or is no longer needed.
- 🇬🇧United Kingdom welly
> Curious why you didn't use trim((string) $var) instead?
Yeah, looking at that post, this seems like a tidier approach. I'll update the merge request and include the changes in the patch, will test it against Drupal 10.
- Status changed to Closed: outdated
11 months ago 1:53pm 12 March 2024 - 🇬🇧United Kingdom welly
I don't think this is necessary any longer looking at the changes made from the D10 compatibility fixes. Let's close this.