- Issue created by @porchlight
- πΊπΈUnited States smustgrave
Can you maybe help me understand. You have code around the ext class but don't want it to apply to external links?
- π¨π¦Canada porchlight
Yeah, we were already using the 'ext' class for something else, not related to external links. We were only using extlink module to open external links in new a tab and add the title attribute to links, but no icon, so it wasn't adding the 'ext' class to all the links. Now with the latest update it is, which is then applying all our "ext" styles to the links, making things look really broken.
Anyways I have fixed our sites by changing our custom templates and css to use a different class name than 'ext'. But this could still throw other people for a loop, maybe its not something that needs to be "fixed" and just something people should be aware of if by chance they were using the module the same way we were AND they had styling attached to an unrelated "ext" class... When I say it out loud it sounds like a real unlikely coincidence. Probably can Close (works as designed) - πΊπΈUnited States smustgrave
Maybe we can add some markup to the settings page saying the "ext" link class will be auto added?
- π¨π¦Canada porchlight
Yeah something like that might help people track down the issue at least if they start seeing strange behaviours.
-
smustgrave β
committed 207bc09f on 2.0.x
Issue #3476529 by porchlight: Add warning to settings page that ext...
-
smustgrave β
committed 207bc09f on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.