- Issue created by @porchlight
- First commit to issue fork.
- πΊπΈUnited States DamienMcKenna NH, USA
Are these API changes in the 8.x-1.x or 2.x branch? That will make a difference on how we decide to handle this. Thank you.
- π¨π¦Canada porchlight
The diff changes were made on the 2.x branch including their 2.0.0-beta1 release.
- First commit to issue fork.
- Status changed to Needs review
7 months ago 11:02pm 23 July 2024 - π¦πΊAustralia acbramley
Pushed to an MR.
This will fix 2.x support and not break 8.x-1.x support (since adding return types on child classes does not break compatibility).
- πΊπΈUnited States DamienMcKenna NH, USA
Thank you for the clarification.
I thought Metatag listed Diff as a dev dependency, apparently not, and there's no test coverage either.
- πΊπΈUnited States DamienMcKenna NH, USA
I created another issue for adding test coverage: π Add test coverage for Diff integration Active
-
DamienMcKenna β
committed 0273f785 on 8.x-1.x
Issue #3460593 by DamienMcKenna, porchlight, acbramley: Update...
-
DamienMcKenna β
committed 0273f785 on 8.x-1.x
-
DamienMcKenna β
committed bdf0a093 on 2.0.x
Issue #3460593 by DamienMcKenna, porchlight, acbramley: Update...
-
DamienMcKenna β
committed bdf0a093 on 2.0.x
- πΊπΈUnited States DamienMcKenna NH, USA
Thank you for your work on this.
Committed to both branches.
- Status changed to Fixed
7 months ago 5:04pm 29 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.