🇬🇧United Kingdom @jofitz

jofitz → made their first commit to this issue’s fork.

Deployed as part of 2.0.2 release

I'm going to work on this to get it released

jofitz → created an issue.

Thanks for the plugin, @kmv.

I don't think there will be a enough need for this modifier but I will link to this issue from the project page so people can find the code if they need to.

Thanks for the plugin, @kmv.

I don't think there will be a enough need for this modifier but I will link to this issue from the project page so people can find the code if they need to.

Great work @k-l, thanks for including the tests too. Don't forget to assign issues to yourself when you are working on them to avoid other people working at the same time. Also set the status to Needs Review (and unassign yourslef) when you have finished working. Thanks!

@deepali sardana thanks for your contribution, but everything in your patch has been covered by @k-l's merge request.

Can someone add to the merge request and include multibyte string functions for UpperCaseFirst and (if possible) TitleCase. Setting back to Needs Work.

xjm → credited jofitz → .

No, I'm afraid not. The config generated by this module is only applicable to this module.

Created merge request

I have simplified the issue title because it appears to affect more than just Boolean fields.

I think 2 separate issues are being discussed here.

1. I have created an MR to fix the The "" plugin does not exist bug.
2. I have created a new issue, with an MR, ( 🐛 Unable to change either the Target or Comparison elements Needs review ) to address the bug with being unable to change either the Target or Comparison elements (first mentioned by @alex.verhoeven, #3371927-12: PluginNotFoundException: The "" plugin does not exist → )

jofitz → created an issue.

jofitz → made their first commit to this issue’s fork.

I would suggest removing uuid from the default $configuration array because it is redundant AFAIK, but it could be argued that change is beyond the scope of this issue:

$configuration += [
  'data' => [],
  'uuid' => '',
];

Once 🐛 YoutubeFieldTest::testYoutubeField Undefined array key "youtube" Active has been committed then these test failures will disappear, therefore this will be ready to merge too.

Setting to RTBC to speed the process along, but if my suggested change is made then I will review again.

All 4 unresolved threads have been addressed.
LGTM

It would be really useful to get this merged and released ASAP to help with test failures on other issues, e.g. 🐛 It is no longer possible to add multiple field states Needs review

Assigning to myself as I take a first pass at the merge request

jofitz → made their first commit to this issue’s fork.

Created merge request

jofitz → created an issue.

I have slightly tweaked @danielwirz patch to remove an additional div wrapper that had crept in. This keeps the markup in line with the previous patch and will avoid css selector issues (which is what I suffered from)

Thanks @ressa, I didn't discover the issue with regions until after is made the edit (sorry about that). Thanks for your addition. I wonder if there's a drush issue about this...

Add alternative method for creating a theme; using drush.

jofitz → created an issue.

jofitz → made their first commit to this issue’s fork.

This has been fixed in 3.58

This has been fixed in 3.58

Patched from #23 no longer applies.

Re-rolled

Corrected re-roll errors in #61 that fed into #62.

(patch written for 10.1.x, but also applies to 11.x)

Include requirements from ip2location-php composer.json

Created patch

jofitz → created an issue.

I suggest this as a more elegant solution.

(no interdiff because it is a completely different approach)

Added cspell:ignore, as suggested.

Status remains at NW because patch still needs tests etc

Deployed to 2.0.x branch

Added tests

@iwant2fly and @klonos, do either of you still require this for D7 or can I bump this to the latest v2.0.x release (for D8/9/10)?

The modifier plugin look great.

Once Unit Tests have been added this can be merged and released.

The modifier plugins look great.

Once Unit Tests have been added this can be merged and released.

jofitz → made their first commit to this issue’s fork.

I have (finally) released v2.0.0 which is compatible with D8/9/10.

I would be grateful to anyone who has the time and inclination to adapt any of the other token modifiers from the 7.x version.

Marking as fixed.

Thanks for the Unit Tests, @sonnykt

jofitz → made their first commit to this issue’s fork.

Change 'ckeditor5/ckeditor5' to 'core/ckeditor5'

jofitz → created an issue.

See ✨ Add support for Ckeditor 5 Needs review

Ignore me. This fix has been deployed, I wasn't reading my error message closely enough.

Can this patch be included in the next release please?

I am encountering this error on D10.1.7, php8.1, Cleantalk 9.3.2

Apologies for all the cruft in that previous patch

Added css to override <td> height.

jofitz → created an issue.

Add an SVG icon

jofitz → created an issue.

Upload patch

jofitz → created an issue.

My suggestion is to loop through all carts for the current user and save them if necessary, prior to restoring a cart.

I have produced the attached patch.

Create patch

jofitz → created an issue.

tbh I couldn't make sense of the description of that issue. But I applied the patch and it did not solve the problem, so I assumed it was different.

jofitz → created an issue.

jofitz → created an issue.

Fix coding style error in patch #32.

jofitz → created an issue.

Correct assert value.

My local test system is not working, but I think this should resolve that test failure.

Also corrected the 3 coding standards errors.

Applied changes in #396 to patch from #394 (ignoring patch in #397). Also replaced some deprecated assert functions.

Rerolled patch from #342.