🇺🇸United States @johnle

Added the fork MR for review. Thanks!

johnle → created an issue.

Code is merged.

@abhishek_gupta1 thanks for doing that. I appreciated.

Patch to add job parameters.

Merged.

johnle → created an issue.

johnle → created an issue.

johnle → created an issue.

was resolved from the issue https://www.drupal.org/project/tmgmt_asymmetric_block/issues/3368067 🐛 Section is not getting updated with the latest source section Fixed

slucero → credited johnle → .

I did my best to try to reroll this to version 2.1.1, there is quite a bit of code refactoring to 2.0 that made it a challenge. This is working, but probably could use some more tweaking + testing + cleanup. One thing I've notice is that some of the code from 1x. is no longer in 2.x like the webp support code.

johnle → created an issue.

Merged

Applied the automated patch from update bot.

johnle → made their first commit to this issue’s fork.

Ok I was able to get this working that resolve the 2 issues above
Added this above the drupal.org patckagelist

{
            "type": "composer",
            "url": "https://packages.drupal.org/8"
},

with:

{
            "type": "package",
            "package": {
                "name": "drupal/entity_reference_purger",
                "type": "drupal-module",
                "version": "dev-3348323-entity-reference-purger",
                "source": {
                    "url": "https://git.drupalcode.org/issue/entity_reference_purger-3348323.git",
                    "type": "git",
                    "reference": "3348323-entity-reference-purger"
                },
                "require": {
                    "drupal/preserve_changed": "^2.0@alpha"
                }
            }
        },
.......

And ran:

composer require drupal/entity_reference_purger:dev-3348323-entity-reference-purger

It seem to installed the require dependencies. I'll need to retest this again with the replacement of the dependencies and the queuing bug that was reported from the patch from my team.

Thanks, I will try pushing the changes to once https://git.drupalcode.org/ is stable again.

@dalin
Thanks for the code review, I'll get all recommended change in place, one thing I am kinda struggling on is when adding a dependencies to preserve_change module, I've ran into the following issue:
* When applying a composer patch, it did not install the require preserve_change change module, likely due to it running the composer install on the module first, and then later on patching it with the composer changes.

+++ b/composer.json
@@ -21,6 +21,7 @@
         "source": "https://git.drupalcode.org/project/entity_reference_purger"
     },
     "require": {
-        "drupal/core": "^8.8.0 || ^9.0 || ^10"
+        "drupal/core": "^8.8.0 || ^9.0 || ^10",
+        "drupal/preserve_changed": "8.8.0 || ^9.0 || ^10"
     }
 }

* Adding the dependencies in the .info.yml file, seem to give conflict. I've tried the suggestion of adding an additional line break, but still no luck.

+++ b/entity_reference_purger.info.yml
@@ -2,3 +2,8 @@ name: 'Entity Reference Purger'
 description: 'Removes orphaned entity references when an entity is deleted.'
 type: module
 core_version_requirement: ^8.8.0 || ^9 || ^10

+dependencies:
+  - preserve_changed:preserve_changed

I think for the time being it might be easier to add the changedItem alter to the module, but use maybe a different key instead so it doesn't conflict with the preserve_change module properties key, what do you think?

Great job on the patch! Here are some bugs that I've updated to resolve from the previous patch
* Sometimes the revisions are not all deleted when a term is removed. I've just re-order the revision so that the main revision is deleted last that way it would not stop the revision from being deleted.
* SetSyncing still update the modified date to the most recent dates of the active revision on all languages, causing an issue with the content nove allowing to save with a message that it has been modified by another user. To fix this, used the code from the https://www.drupal.org/project/preserve_changed → to keep the modified dates untouched if we are not creating a revision.
* Minor coding standard fixes and comments.

Created a patch for the latest MR

johnle → created an issue.

Code has been tested and merged.

johnle → created an issue.

We now are able to use the Patternkit field processor plugins to render content base on text format. This is no longer necessary.

Added patch to allow entity translation instead of using the node.

johnle → created an issue.

Code has been merged into dev.

Fixed warning message with undefined array index provider.

Fix a small bug where the original node was used with the untranslated field instead of the latest translation node before applying block translation.

Refactor the code so that we no longer have to worry about looping through each section every time a job item is process. Move most of the logic to when the Job is finished running to add the blocks into layout builder for translation.

This will improved the overall performance and create single revision per event subscribed.

Fixed from code review

At some point the language contains additional duplicated stale block and is incremented, added a patch to ensure if using a file, and the file import is containing more than what needs to be translated, it will reset the block translation

Running into an issue when trying to import an already existing translation which also causes duplicates. To get around this, I am checking to see if the new block count is the same block count as the original and clear all it all re-import the blocks, and also take account for the custom block type uses as reference.

Tested this against the dev branch and that is now working.

Ready for review.

Tested this and is working now.

johnle → created an issue.

johnle → created an issue.

Looks like a timing issue. Because the ckeditor5 create method return a promise, there is no way to bind any action on the event. I do see a patch created to allow the ability to bind on "ckeditor5.create". here https://www.drupal.org/project/drupal/issues/3319358 ✨ Trigger event when Text Editor is attached Needs work .

I think the block issue is unrelated, I see that it's using ckeditor module vs ckeditor5 there.

@minsharm thanks for testing this! Let me see if I can reproduce the issue you are getting.