I tried now with Webform 6.2.3 and Gin 8.x-3.0-rc12 + https://git.drupalcode.org/project/gin/-/merge_requests/447.patch from https://www.drupal.org/project/gin/issues/3457385 🐛 Form buttons missing in modal/off-canvas Needs review .
The extra "Save elements" button doesn't seem to appear anymore below the form after the first save. However, the changes in form still seem to be saved only on the first save.
See https://www.drupal.org/files/issues/2024-07-04/webform-sticky-actions-2.mov → for a screen recording.
Thanks for the suggestion. I applied both of those as patches, but unfortunately those didn't seem to help for this problem.
Wondering if the problem could be related to this https://git.drupalcode.org/project/gin/-/blob/8.x-3.0-rc12/src/GinConten..., which I understood is only set once.
Before the first save the form has attribute id="webform-edit-form" and the "Save elements" button has attribute form="webform-edit-form", so it's pointing to the correct form.
After the first save the form's id attribute will get updated (eg. to id="webform-edit-form--qUJYQPo7zqs"), but the "Save elements" button still has form="webform-edit-form".
ilkkave → created an issue.
Thanks. Confirming that works now with Webform listings too.
Thanks for the patch. The "admin/content" view looks now good with it.
I also tried the patch with Webform module, and there seems to be still so problems with listings provided by it, at least with the following ones:
Webforms listing →
Webform results →
Webforms: Variants configuration →
Here's a patch based on the previous one, that changes few of the selectors to use closest() instead of parent() to make things work with Gin 8.x-3.0-rc5. Also few minor tweaks to put results of those selectors in reusable variables.
This doesn't seem to work anymore with Gin 8.x-3.0-rc5. Gin seems to now have some extra wrappers around the table, causing the table and form actions not to be siblings anymore, which the patch relies on.
https://git.drupalcode.org/project/gin/-/commit/1a6fb153927b357466761e72... is the related commit in Gin, which causes those changes to wrappers.
Minor detail, but comparing what happens when there's a scrollbar.
From left to right: 8.x-3.0-rc2, 8.x-3.0-rc3, 8.x-3.0-rc3 with this patch.