[webform] Sticky action buttons not working sequently in webforms elements form

Can you check if either of the fixes from 🐛 Sticky action buttons doesn't save shipping method Needs review and/or 🐛 Form buttons missing in modal/off-canvas Needs review will fix this issues? Thanks!

Thanks for the suggestion. I applied both of those as patches, but unfortunately those didn't seem to help for this problem.

Wondering if the problem could be related to this https://git.drupalcode.org/project/gin/-/blob/8.x-3.0-rc12/src/GinConten..., which I understood is only set once.

Before the first save the form has attribute id="webform-edit-form" and the "Save elements" button has attribute form="webform-edit-form", so it's pointing to the correct form.

After the first save the form's id attribute will get updated (eg. to id="webform-edit-form--qUJYQPo7zqs"), but the "Save elements" button still has form="webform-edit-form".

The latest changes from 🐛 Form buttons missing in modal/off-canvas Needs review should fix this issue 👀

@ilkkave can you confirm? Thank you!

I tried now with Webform 6.2.3 and Gin 8.x-3.0-rc12 + https://git.drupalcode.org/project/gin/-/merge_requests/447.patch from https://www.drupal.org/project/gin/issues/3457385 🐛 Form buttons missing in modal/off-canvas Needs review .

The extra "Save elements" button doesn't seem to appear anymore below the form after the first save. However, the changes in form still seem to be saved only on the first save.

See https://www.drupal.org/files/issues/2024-07-04/webform-sticky-actions-2.mov → for a screen recording.

I suspect there is a sequencing issue when the form builder/manager is reloaded via Ajax.

@jrockowitz could we fix this with adding a dependency on the corresponding webform library?

See also the efforts in 🐛 Form buttons missing in modal/off-canvas Needs review

I've uploaded a patch to ignore webforms elements form as a temporary solution until we figured out (hopefully together with the webforms team) why this single form does not work sequently

I believe this may also need to ignore the form_id "webform_ui_element_form" as well. With the patch I still see a missing Save button if the form element throws a validation error.

1. Add Custom composite element
2. Enter a title and press Save.
3. A form validation error is presented and the Save button is no longer visible.

Hi all. I know this issue is about webform, but I also have a save button problem with feeds. I didn't want to open a new issue since it isn't a serious problem. When I want to add a new feed content or edit a feed content, the text on the save button does not appear unless I hover over the button. However, the button works fine. I uploaded a screen record of it. I have Gin 8.x-3.0-rc13 and Feeds 8.x-3.0-beta5 on Drupal 10.3.1.

saschaeggi → changed the visibility of the branch 3458520-sticky-action-buttons to hidden.

saschaeggi → changed the visibility of the branch 3458520-sticky-action-buttons-3x to hidden.

The latest changes in 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review do address the reported issues here. Needs to be verified.

Hi folks, I am going to check 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review actually solve this issue.

The issue looks solved by [3463796]. Attaching the screen recording.

Let's close this as outdated in favor of the 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review .