- Status changed to Needs work
over 1 year ago 8:28am 14 August 2023 - 🇫🇮Finland ilkkave
This doesn't seem to work anymore with Gin 8.x-3.0-rc5. Gin seems to now have some extra wrappers around the table, causing the table and form actions not to be siblings anymore, which the patch relies on.
https://git.drupalcode.org/project/gin/-/commit/1a6fb153927b357466761e72... is the related commit in Gin, which causes those changes to wrappers.
- Status changed to Needs review
over 1 year ago 10:25am 14 August 2023 - last update
over 1 year ago 180 pass - 🇫🇮Finland ilkkave
Here's a patch based on the previous one, that changes few of the selectors to use
closest()
instead ofparent()
to make things work with Gin 8.x-3.0-rc5. Also few minor tweaks to put results of those selectors in reusable variables. - Status changed to RTBC
over 1 year ago 12:33pm 14 August 2023 - 🇩🇪Germany marcoliver Neuss, NRW, Germany
The patch from #17 🐛 Button "Add above" is missing with Gin theme enabled Fixed appears to fix the issue.
- Status changed to Fixed
over 1 year ago 9:11pm 30 August 2023 - 🇨🇭Switzerland berdir Switzerland
Also still works with the claro patch.
When updating existing patches with changes like this, please provide interdiffs so it's easier to review.
Automatically closed - issue fixed for 2 weeks with no activity.