- Issue created by @kryber
- ๐ฏ๐ดJordan Rajab Natshah Jordan
Rajab Natshah โ made their first commit to this issueโs fork.
- @rajab-natshah opened merge request.
- Status changed to Needs review
over 1 year ago 9:55am 2 May 2023 - ๐ฏ๐ดJordan Rajab Natshah Jordan
Have a custom space to fit the squire Custom logo in the Gin Toolbar
to fit with the new hover and focus way from toolbar after Admin Toolbar 3.3.1 was released - Status changed to Needs work
over 1 year ago 10:04am 2 May 2023 - ๐ฏ๐ดJordan Rajab Natshah Jordan
The fix is only working with Sidebar, Vertical Toolbar (Default) and Legacy, Classic Drupal Toolbar
But, still having the issue with
- Horizontal, Modern Toolbar
- Status changed to Needs review
over 1 year ago 11:07am 2 May 2023 - ๐ฏ๐ดJordan Rajab Natshah Jordan
Moving this issue to Needs review
Not sure if
the arrow will overlap with the logo for
"Horizontal, Modern Toolbar"
Navigation (Drupal Toolbar)should be fixed in this issue
- ๐ฏ๐ดJordan Rajab Natshah Jordan
Number of testing cases for this issue is big with light and dark mode.
Tested in LTR and RTL - ๐ซ๐ฎFinland ilkkave
Minor detail, but comparing what happens when there's a scrollbar.
From left to right: 8.x-3.0-rc2, 8.x-3.0-rc3, 8.x-3.0-rc3 with this patch.
- Status changed to Needs work
over 1 year ago 8:30am 7 May 2023 - ๐ฏ๐ดJordan Rajab Natshah Jordan
Thanks, Ilkka for the follow up test on this issue.
I confirm the issue when having a scrollbar over the toolbar.
It happens:When the toolbar has many root links
And the height of the Browser window is smallShould the toolbar has a scrollbar?
Or re-style to fit custom logos in with the scrollbar?Happy with any fix for this issue.
- First commit to issue fork.
-
saschaeggi โ
committed 5990cf98 on 8.x-3.x authored by
Rajab Natshah โ
Issue #3357587: Fix Custom logo in toolbar floated on left
-
saschaeggi โ
committed 5990cf98 on 8.x-3.x authored by
Rajab Natshah โ
- Status changed to Fixed
over 1 year ago 8:03pm 8 May 2023 - ๐จ๐ญSwitzerland saschaeggi Zurich
Re-added the
display: block;
as admin_toolbar has removed it and this has caused the display issue.Thanks for reporting and your efforts! ๐
Automatically closed - issue fixed for 2 weeks with no activity.