🇫🇷France @Simon Georges

Indeed, this label shows when you use the "Move" feature as well, so it's hard to know which block we are moving :-)

I think I have this issue as well (on latest Webform version).

@codechefmarc, the patch works for me in the Layout Builder as well, so I'm wondering what contrib module I have that could alter this... I'll check back at work this week, thanks for your feedback!

In my case, the patch in #17 was allowing the prepare_form to execute for Inline Blocks, but the form was not actually correctly prepared. Fix the attached fix, it works for me... Let's hope it's the case for all of you as well ;-)

We are currently working with some content types with a very "fixed" template, where each region can only accomodate only 1 component. In that case, the dropdown feels a better option, while for our other content types, having the pop-over with the list of components is nicer. I was just about to create a feature request to have the possibility to choose the UX depending on the entity bundle :-D

Simon Georges → created an issue.

(in our case, we wanted to add a custom class on the link to be able to style it specifically)

The previous patch cannot work, considering it will add a "/" on external urls before testing them for externality, so the patch in #5 is the correct one, and still applies cleanly on current version.

As "Configuration" is not using the same Controller (but \Drupal\system\Controller\SystemController::overview), people still see the "Configuration" menu. Adding a $route->setRequirement('_access_admin_menu_block_page', 'TRUE'); using a custom RouteSubscriber seems to work, but I am wondering if this behavior is expected or if you did not take that into account for a reason.

We can agree :)

Actually, I still have the bug where the second resize is not saved (style & data-width values are not updated if I looked at the source).

Ok, I think I found it...

It comes from the following code:

.drupal-media.ck-widget_with-resizer .media {
  width: 100% !important;
}

Olivero theme adds the "media" class in the media.html.twig, but we did not have it in our custom theme. I don't know if it's a bug or not, considering "starterkit-theme" adds the "media" class, we may consider this is the recommend way to start a theme in Drupal 10, and expect people to have that class, but it should at least be documented or adjusted, don't you think?

Actually, if it only works with Olivero as a front-end theme (which I can reproduce), it means that something is missing in the module, doesn't it? (considering we are working on a back-office page, why does the front-office current theme plays a role? Could there be a library-extend missing from the module?)

Simon Georges → created an issue.

@DamienMcKenna, I seem to have an issue with my custom theme as well, do you happen to have fixed yours? Can you share what the fix was?

My current issue is:

image-style-configuration-definition-invalid 
Object { dropdown: {…} }
​
dropdown: Object { name: "drupalMedia:viewMode", display: "listDropdown", defaultItem: "drupalElementStyle:viewMode:default", … }
​
<prototype>: Object { … }
 
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-image-style-configuration-definition-invalid

I was there and was mostly coordinating & validating. We worked on Drupal core, Webform, Smart Date. Some hard strings to translate, but a good dedicated team effort \o/

It may still be relevant today ;-)

I concur, the performance gain is impressive (1 to 2 seconds saved on a 4 to 5 seconds load time in our case). Thanks for the patch!

Considering several people have reported it working without drawbacks, let's try to move it forward ;-)

Hello,

I am closing this issue as a duplicate 📌 Automated Drupal 10 compatibility fixes Fixed , which already contains a patch with the same modifications (and more).

Changing status to "Needs review", considering a patch is included.

Simon Georges → created an issue.

Simon Georges → created an issue.