- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Looking promising!
- This needs to have preliminary internal HTTP API support. "preliminary", because it might be imperfect, and that's fine. But we need to have the FE folks unblocked to build the entire feature; we can then still refine it later ๐
- That MUST come with updated test coverage in
\Drupal\Tests\experience_builder\Functional\XbConfigEntityHttpApiTest::testJavaScriptComponent()
- Some missing test coverage to ensure that saved config entities in config entity storage do not actually contain these base64 blobs
- ๐ฆ๐บAustralia mstrelan
Re polyfill:
Regardless of core version no reason XB couldn't add it as a dep, just give it a loose constraint so it doesn't conflict with core. - ๐ซ๐ฎFinland lauriii Finland
We can work around this in beta by uploading images to media library and manually referencing them in component code. This is obviously not great and doesn't allow components to be moved from environment to another so we definitely still need this. Just trying to avoid rushing this before the beta.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
#6: That should be fine, because XB bumped its requirement to 11.2 in ๐ PHPUnit Next Major tests failing Active ? That's what's in 0.5.0-alpha1 โ , so <0.5 is for Drupal <11.2, >=0.5 is for Drupal >=11.2
That was pretty fast! Reviewingโฆ ๐ค
- ๐ฌ๐งUnited Kingdom f.mazeikis Brighton
Pushed all the work so far, including working tests. @larowlan had some feedback, I think I've addressed most of it, but happy to get back to it if there's more.
Moving into ready for review.
- ๐ฆ๐บAustralia mstrelan
This seems very similar to ๐ Invalidate rendered cache tag if config.system.site translate Postponed: needs info which I wasn't able to reproduce. Tried to reproduce this as well and couldn't. Can we please get steps to reproduce? Here's what I tried.
- Install Drupal 11.x with standard profile, includes dynamic page cache and page cache modules
- Ensure render cache is not disabled in settings.php
- Visit the home page as an anonymous user, observe site name in the branding block
drush config-set system.site name "Test 1"
- Repeat step 3