Views RSS view mode settings are completely broken

Created on 26 October 2015, about 9 years ago

Updated 21 February 2024, 9 months ago

Follow-up to #2409413: Remove fields that do nothing from the "RSS publishing" settings form →

Problem/Motivation

'title' is a special view mode hacked into the plugins. The default view mode 'rss' is provided by core but once you change the form you can never re-select. The teaser view mode might exist. The fulltext view mode almost certainly does not. I think we should fix all the view mode wonky-ness in another patch as it is likely to be hard. Basically, the whole view mode setting is currently very broken :(

    $form['feed_view_mode'] = array(
      '#type' => 'select',
      '#title' => t('Feed content'),
      '#default_value' => $this->config('system.rss')->get('items.view_mode'),
      '#options' => array(
        'title' => t('Titles only'),
        'teaser' => t('Titles plus teaser'),
        'fulltext' => t('Full text'),
      ),
      '#description' => t('Global setting for the default display of content items in each feed.')
    );

And the default value is RSS :(

Oh and the views are missing dependencies on the correct view mode if the default system view mode is used. What a mess.

Proposed resolution

Remaining tasks

User interface changes

API changes

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

System →

Last updated about 16 hours ago

No maintainer

Created by

🇬🇧United Kingdom alexpott 🇪🇺🌍

Live updates comments and jobs are added and updated live.

Needs upgrade path

Needs upgrade path tests

missing config dependencies

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Configuration schema

validation

blocker

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment 9 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This blocks 📌 Add validation constraints to all system.* simple config (except system.rss) Needs work and 🌱 [meta] Add constraints to all simple configuration Active .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024