- ๐ณ๐ฑNetherlands bbrala Netherlands
Well at least everything is green. So thats good. But it some weirdness with the event subscriber. Not sure how that should work. I didn't investigate the redirects and such. Mostly just refactored the current recent patch to work with an event subscriber.
- ๐ณ๐ฑNetherlands bbrala Netherlands
I played around with this and moved the implementation to a eventsubscriber as asked for by @znerol. I see one things that is very weird though as per comment in the code:
/** * Either Drupal\Tests\page_cache\Functional\PageCacheVaryTest::testPageCacheWithVary * fails or Drupal\Tests\language\Functional\LanguageBrowserDetectionAcceptLanguageTest::testAcceptLanguageEmptyDefault * fails if you remove one of those. Not sure why */ $events[KernelEvents::RESPONSE][] = ['onRespond', -100]; $events[KernelEvents::RESPONSE][] = ['onRespond', 100]; return $events;
Not sure why, those priorities sometimes confuse me a little.
- @bbrala opened merge request.
- ๐ณ๐ฑNetherlands bbrala Netherlands
bbrala โ changed the visibility of the branch 2430335-browser-language-detection to active.