Remove weight field from menu item entity forms

"needs accessibility review" was added when there was a patch that altered the menu list.

Since then, all iterations are just removing the weight from the menu section of entity forms. - There was no a11y concern about that and is arguably an accessibility improvement. The weights are only useful as they relate to weights of sibling items within a menu, and it's probably best to not give anyone the accidental impression that reordering items in a menu requires having multiple node form tabs open to compare weights.

I started with the patch in #35 and then simply worked on the tests.

So had to run locally as I couldn't run the test-only feature

Reverted the changes besides the 2 test files

Only ran MenuUiNodeTest::testMenuNodeFormWidget as that was the one that had new assertions added. Got

Behat\Mink\Exception\ElementNotFoundException : Form hidden field with id|name|value "menu[weight]" not found.

So test coverage is there

Issue summary appears complete and code change appears to line up.

Maybe we should consider opening a follow-up for some next steps. I think the first next step would be to always add the new menu item to the end of the list. Another next step would be trying to come up with a better UI for users to select where the new menu link should be added.

I think this also needs a change record.

This affects the UX (in a positive way!) and may break some contrib tests so it indeed needs a change record. Perhaps it should also get a Drupal 10.3 release note?

Also, the issue summary states there's no UI changes, whereas that's literally the goal of this issue 😅 Also, the title says "menu item entity forms" — but it's specifically only node forms? (This modifies menu_ui_form_node_form_alter() after all.) The current title would make for a confusing commit message.

(This issue piqued my curiosity because based on the title it seemed related to 📌 Deprecate vocabulary weight property Needs work , but it is not. Hence my request to clarify all that.)