- Issue created by @wim leers
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
This is now trivial to add test coverage for thanks to š Expand `::getClientSideInfo()` test to all ComponentSource plugins Active . All we'd need to do is:
- override
ComponentSourceTestBase::testGetClientSideInfo()
inJsComponentTest
to create a draft component for one of the tested code components - update expectations.
- override
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
#5.1 is conceptually super similar to š Auto-saved changes to component are not loaded in preview canvas when component is inside a slot Active ā chances are you can copy/paste some code, or, better yet, extract it into a trait for testing purposes! š
- šŗšøUnited States hooroomoo
Just an FYI, this regression was introduced yesterday š Hovered preview for JS components in library not working Active .
- First commit to issue fork.
- Merge request !976#3516705 - Auto-saved changes to code components are not visible in preview-on-hover-component-list until published ā (Merged) created by thoward216
- š®š³India sanket.tale
I reviewed the proposed solution and merge request, and it looks good overall. However, the pipeline is still failing. I tried to solve it, but couldn't resolve the issue. I believe the failure is due to the image (600x400.png) unexpectedly being found in the iframe and the client.js script not loading correctly. Please check the image logic and ensure the script loads properly during testing.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Yep, genuine test failure:
ā Get client side info ā ā Failed finding selector 'script[blocking="render"][src*="experience_builder/ui/lib/astro-hydration/dist/client.js"]' ā Failed asserting that 0 is equal to 1 or is greater than 1. ā ā /builds/issue/experience_builder-3516705/tests/src/Kernel/Plugin/ExperienceBuilder/ComponentSource/ComponentSourceTestBase.php:336 ā /builds/issue/experience_builder-3516705/tests/src/Kernel/Plugin/ExperienceBuilder/ComponentSource/ComponentSourceTestBase.php:363 ā /builds/issue/experience_builder-3516705/tests/src/Kernel/Plugin/ExperienceBuilder/ComponentSource/JsComponentTest.php:756 ā“
So I'm confused about why this was marked ? š¤
- šŗšøUnited States tedbow Ithaca, NY, USA
This makes the problem in š JS component slots don't appear in the preview canvas until published Active worse because since it no longer showed the saved config compiled js for hovering and since auto-save doesn't work either there is no preview on hover
- š¬š§United Kingdom thoward216
@tedbow re #14 š Changes to code components are not visible in preview-on-hover-component-list until published Active - are you saying that š JS component slots don't appear in the preview canvas until published Active is the root cause of the failing test here? And that issue should be resolved first?
- šŗšøUnited States tedbow Ithaca, NY, USA
@thoward216 nope I assume this should be able to be fixed here. Just related to the other problem. in manual testing of this MR I do see it fixing the problem of hover preview not being updated
- š¦šŗAustralia larowlan š¦šŗš.au GMT+10
wim leers ā credited larowlan ā .
-
wim leers ā
committed c353c399 on 0.x authored by
thoward216 ā
Issue #3516705 by thoward216, wim leers, tedbow, larowlan: Auto-saved...
-
wim leers ā
committed c353c399 on 0.x authored by
thoward216 ā
Issue 1: Preview not updating after modifying component properties
- Steps to Reproduce:
- Click on the + Add New button.
- Keep the default JS code as it is and click on Add to components from the side panel.
- Edit component by changing its background color to
bg-blue-200
. - The right-hand preview section displays the correct color change.
- Navigate back to the Canvas page from the navigator.
- Hover over the card component.
- Observation: It seems that navigating back to the canvas is not triggering an update or cache refresh for the hover preview. The component is still stuck with the initial preview state.
Issue 2: Inconsistent updates after drag-drop and publish
- Steps to Reproduce:
- Drag and drop the component onto the page.
- Publish the changes and reload the page.
- The changes are correctly reflected.
- Edit the card again and change the background color to
bg-blue-500
. - Navigate back to the Canvas page.
- Hover over the card component.
- Expected: The new background color should be visible both in the canvas and on hover.
- Actual: The hover preview and canvas still display the previous state (
bg-blue-200
).
- Steps to Reproduce:
- š«š®Finland lauriii Finland
@mayur-sose I can reproduce both issues. Could you file new issues for these? š
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
@mayur-sose and please leave a comment here linking to those š
Created 2 issues:
- #3523128 š Code component preview not updating after modifications Active
- #3523130 š Canvas and hover preview out of sync after drag-drop and publish Active
Automatically closed - issue fixed for 2 weeks with no activity.