- Issue created by @wim leers
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Sibling: 📌 ComponentSource robustness: add `ComponentSourceTestBase::testSettings()` Active .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Sibling: 📌 ComponentSource robustness: add `ComponentSourceTestBase::testSettings()` Active .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Sibling: 📌 ComponentSource robustness: add `ComponentSourceTestBase::testSettings()` Active .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@danielveza: How is this going? Are you still actively working on this? 📌 ComponentSource robustness: add `ComponentSourceTestBase::testSettings()` Active is in, this is the next step!
- Merge request !932Issue #3518832: Move testGetClientSideInfo to ComponentSourceTestBase and... → (Merged) created by isholgueras
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
On it!
Just cross-posted actually 😄 This will also make 🐛 Changes to code components are not visible in preview-on-hover-component-list until published Active easier 👍
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
While the tests are passing, I think they're still missing some of the clarity I'm looking for to build enough confidence and allow these tests to be efficiently updated+expanded in the future.
🏓
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This was 95% ready! 👏
I just had to do some minor refactoring to achieve the test simplicity+robustness I was looking for.
In doing so, I discovered a bug, which is exactly why I was insisting for that test simplicity — I didn't spot the bug during review either, it's only thanks to the refactor to simplify the test logic itself that this bug was revealed! 😄
-
wim leers →
committed 21f0dc30 on 0.x authored by
isholgueras →
Issue #3518832 by isholgueras, wim leers: ComponentSource robustness:...
-
wim leers →
committed 21f0dc30 on 0.x authored by
isholgueras →
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This unblocked 🐛 Changes to code components are not visible in preview-on-hover-component-list until published Active 🥳
Automatically closed - issue fixed for 2 weeks with no activity.