Auto-saved changes to component are not loaded in preview canvas when component is inside a slot

wim leers → credited larowlan → .

We missed this in 📌 Code Components should render with their auto-saved state(if any) when rendered in the XB UI Active .

I went ahead and merged the MR — after thorough manual testing and reviewing the code. Keeping the issue open to add the necessary tests.

Now let's add the missing tests.

Tests are failing, so no, it's not that simple 😄

When previewing, there are none of those wrapping HTML comments. So all the existing test expectations are no longer met.

Did you see @larowlan's test suggestion of 2 days ago on the already-merged MR?

Oh, I see. I've ran only the tests for ComponentTreeHydratedTest locally and it passed, but fails for omponentTreeHydratedWithBlockOverride

If there are no comments, but the ComponentTreeHydratedTest tests pass... maybe there is something wrong here. I'll check.

Ok, I'll add more options to test.

Thanks!

I've added the isPreview:true option to every single test to validate each.

When previewing, there are none of those wrapping HTML comments. So all the existing test expectations are no longer met.

I couldn't see any output difference (in terms of wrapping html comments). Everything is handled by each renderComponent

• For BlockComponent, is only being used for$build['#xb_preview'] = $isPreview;.
• For SingleDirectoryComponent, $isPreviewis not being used.
• For JsComponent, $isPreview; is being used to generate the component URL, the CssLibrary, scopedDependencies, libraries and for the autosave.

With this in mind, the component types that are being tested in the root are SDC and Block (with the OverrideTest), but no JsComponent. JsComponent are added in the slots.

Should we add test for them too in the uuid-in-root ?

I couldn't see any output difference (in terms of wrapping html comments).

Out of scope here — that's being handled in 📌 Only run XbTwigExtension inside XBPreviewRenderer Active .

[the different ways that isPreview is being respected

Out of scope here, being handled in ✨ Consider adding "in_preview" var to components Active .

What's missing here, and which will cause an output difference: a draft JavaScriptComponent config entity existing. Specifically, given the existing tests use it: a draft of the my-cta code component. Add something like this to \Drupal\Tests\experience_builder\Kernel\DataType\ComponentTreeHydratedTest::test():

    // But store an overridden version in auto-save (draft).
    /** @var \Drupal\experience_builder\AutoSave\AutoSaveManager $autoSave */
    $autoSave = $this->container->get(AutoSaveManager::class);
    $autoSave->save($code_component, $saved_component_values);

(source: \Drupal\Tests\experience_builder\Kernel\ApiLayoutControllerPostTest::testWithDraftCodeComponent())

That will cause "draft CSS+JS code component URLs" to appear in the resulting HTML.

That will cause "draft CSS+JS code component URLs" to appear in the resulting HTML

Perfect, I'll work on that. Thanks!

#17 is not yet implemented, but this MR is sure looking great, plus I learned something new about PHP from @isholgueras! 😄

That remaining piece of #17 is coming up again over at #3516705-5: Auto-saved changes to code components are not visible in preview-on-hover-component-list until published → ! 😄

I think it's ready for review.

The only difference that I've found in JavaScriptComponents is when is a draft in preview, but I've tested, in a separate tests, the 4 different options, JavascriptComponent regular, in draft, in preview and draft in preview.

I've also adapted the tests for the BlockOverride, that otherwise it fails.

There is a conflict with 0.x that I need to work on.

Merge with 0.x is now complete and now the expected #is_preview works well. If I set it as preview, it returns the '#is_preview' => TRUE, otherwise is FALSE.

After rebasing 0.x all tests successfully failed 🤣.

Now it's ready for review.

Automatically closed - issue fixed for 2 weeks with no activity.