Auto save shows a change when there is not one

wim leers → credited hooroomoo → .

Originally reported by @hooroomoo at #3509270-13: Status badge and "Review changes" only update after ~10 seconds → , with a GIF. @longwave couldn't reproduce in #16 over there. Full explanation for why by @larowlan at #3509270-17: Status badge and "Review changes" only update after ~10 seconds → after he paired with @hooroomoo.

Nice work, both of you! 🤘

going to work on another issue

back to this one 🔨

This lead me to discover 🐛 Trying to repulish a node that has an existing no props component does not work Active . I think we should just commit this issue with the key sorting for now and the test coverage for that. Then see what the larger problem is for components without props

Assigning to @larowlan as he is the only one that covers all the CODEOWNER areas

The issue is still reproducible by following the steps in the description.

Thanks, @traviscarden!

Also: missing Kernel test coverage. 🙏

I have updated the steps to reproduce because I think the original problem found on [#16007273]
- https://www.drupal.org/comment/16007273#comment-16007273 →
did involve changing the the title

I think it was caused by the different ordering of keys under components.

I think there 2 things going on that can cause the "Review 1 change" problem after you publish

1. the keys under a component are in a different order
2. If you interact the Page Data form, then values in entity_form_fields, are not exactly the same

I think the sorting I added solves 1). I started to work on 2) and got some ways in making entity_form_fields but not completely. I think that is going to be tricky to solve so I am going to open up another issue for that. I reverted my tries to fix it.

create 🐛 Changing a value in Page form then publishing, Auto-save shows a change when there is not one Active for 2nd problem mentioned in #17

It looks like this is ready for @mayur-sose. I'm not able to assign it to him directly, so I'll him to come claim it, and I'll assign it to myself in the meantime so no one else works on it at the same time.

Also, does this actually still need tests per the Issue tags?

@traviscarden nope it has tests now

I'm assuming @mayur-sose will confirm this is fixed — if not, he'll mark this as again and we can do a second MR.

I have followed below steps to reproduce the issue :
1) Create node
2) Edit in XB
3) Change the title
4) Publish all changes
5) Close the dialog
6) Wait for few second and click anywhere on the page
7) Then it report there is 1 new change even though you did nothing

@mayur-sose sorry. The instructions for reproducing the issue have changed since the issue started see #17. The current summary has the new instructions

The title problem was split off into 🐛 Changing a value in Page form then publishing, Auto-save shows a change when there is not one Active which still is not fixed.

Can you test this with the updated instructions in the summary as they are now? Thanks.

Also re

6) Wait for few second and click anywhere on the page

I think the client only calls back the server every 10 secs to check for new changes, so you should wait 11 to be safe(though the change might show up soon depending on when it last checked)

I am not sure that clicking anywhere on the page is necessary.

The wait could have been updated but I am not aware that it has

I tested it, and it works now. Thanks, all. 🙂

Automatically closed - issue fixed for 2 weeks with no activity.