Changing a value in Page form then publishing, Auto-save shows a change when there is not one

This seems like a similar problem space to 📌 Media Library dialogs triggered from page data do not have buttons yet Active because that is changing on the way entity_form_fields is set

So far all I have done in the merge request is bring over my attempts in 🐛 Auto save shows a change when there is not one Active to try to make entity_form_fields not show a difference after entity is published and there no additional changes. That was before I split that problem in to this issue

The current changes do reduced number of changes in entity_form_fields but didn't eliminate them

I did some further manual testing.

it seems that with the current MR and the standard profile the parts of entity_form_fields that still change are field_tags and field_image, both entity reference fields.

So I

1. Installed the standard profile and enabled xb_dev_standard
2. deleted both the tags and images field from Article
3. created an article
4. opened it in XB
5. changed the title
6. published the change
7. waited for 10 seconds to see if "review 1 change" showed

In the MR there doesn't result in "review 1 change" but 0.x does

In 0.x the difference between the call from AutoSaveManager::recordInitialClientSideRepresentation and AutoSaveManager::save is in save() there are 2 extra items under entity_form_fields ,advanced__active_tab and revision

🐛 ImageItem::defaultStorageSettings should override display_default Active is the core bug

Reviewed & RTBC'd the core issue.

Obviously we need tests because nothing is failing now because of this. Also should be stable blocker

I wonder if we want a more complex e2e test where we say start with no media item select load a media item and then remove it again. This should return to the start state and not show a change but I wonder if it actually would

Without the core fix or a workaround tests fail in the media library branch - exactly as we'd expect them to. So this may end up being solved by 📌 Media Library dialogs triggered from page data do not have buttons yet Active

Postponing on that issue

📌 Media Library dialogs triggered from page data do not have buttons yet Active landed.

FYI: thanks to @longwave, 🐛 ImageItem::defaultStorageSettings should override display_default Active already landed in core, but it hasn't shipped in a release yet.

I think 📌 Media Library dialogs triggered from page data do not have buttons yet Active caused 🐛 "There are no users matching "/" whe publishing a node Active . Think we need to postpone on that because it changes the entity fields and will always show a change after publish

Is this still relevant?

If it is, this sounds like a beta blocker because it'd drive any user insane.

There are two scenarios mentioned in the issue description, but only one is currently reproducible. Below is the scenario that reproduces the issue:

Steps to reproduce:

1. Create a node.
2. Edit the node in Experience Builder (XB).
3. Change the node title (or possibly any field in Page Data).
4. Wait for approximately 12 seconds to ensure the auto-save is triggered.
5. Observe that the "Review 1 change" prompt appears.
6. Revert the node title back to its original value.
7. Wait another 12 seconds.
8. The "Review 1 change" prompt still appears, even though the change has been reverted.
9. Reload the page.
10. The "Review 1 change" prompt still persists despite no actual change being present.

This suggests that reverted changes are not being properly cleared from the change tracking logic.

In that edge-case, I'd assume there is a change: the updated timestamp.
Not sure how we would like to handle it, but IMHO works as expected.

I don't think this is a beta or stable blocker but would be a good to prioritize this with other non-blocking bugs.