Trying to repulish a node that has an existing no props component does not work

(the empty model entry for the drupicon component does really have any extra info)

should this be ?

This will affect any page with a no-props component and it is not clear to the user what the problem is

None of the test failed with "No props sources stored..." error I mentioned in the comments. Probably this means we don't test this situation. It don't think it happens if you try to publish an XB field that you just added a no-props component. It only happens when it was only published once with a no-props component and then you publish again.

Will try to update \Drupal\Tests\experience_builder\Kernel\ApiAutoSaveControllerTest::testApiAutoSaveControllerPost with a test case for this

Going to take a break from this right now, so unassigning myself.

There are 2 different MR's

1. 795 changes to handle a component not having if an input for a component if \Drupal\experience_builder\ComponentSource\ComponentSourceInterface::requiresExplicitInput returns for false for the component
2. 759 just makes sure \Drupal\experience_builder\Controller\ApiLayoutController::buildLayout() sets an empty array in the model if \Drupal\experience_builder\ComponentSource\ComponentSourceInterface::requiresExplicitInput returns for false for the component

795 personally feels more correct for me.

based on @larowlan approval

whoops, forgot this needs tests

tedbow → closed merge request !759

Seems reasonable.
I imagine the unit test will be difficult to unpick in the future - its a shame we couldn't modify a functional test to test the real thing - but we can deal with that in the future