Handle comms around Navigation being experimental

I think it makes sense to hide it given the stability of the Navigation module at this point. Not sure how, though.

If we have active code in Drupal CMS, we can add an info alter hook to alter the info key :)

We don't in Drupal CMS itself (we only have Olivero, nothing for admin pages) but we can do it in gin_toolbar. They are already altering out the warning about using Toolbar and Navigation. 🐛 Temporarily suppress toolbar & navigation warning Needs review

+1 for doing that in gin

If anyone knows how to implement line 627 of the MR better to also address phpcs concerns please do as I am still new to this!

+1 for doing it in gin and/or at the Drupal CMS level somehow.

Doing it in core would introduce an additional pseudo status of experimental-but-really-its-fine → , which we'd probably want to avoid for other things that might be tempted to take that course as well.

There's still a PHPCS issue, but this works as intended. It hides the warning for Navigation but still shows it for other modules, e.g. Field Layout.

Can we scope this to Drupal CMS only?

@saschaeggi we don't have a way to do it within Drupal CMS, as we don't have any active code on the admin side (we have an Olivero subtheme on the front end). I'm not sure of another way to scope it but can certainly understand if you don't want this to go in Gin! We can live with the warning until Navigation is stable.

That's a bummer. I see more situations where we do certain things where we only want to target Drupal CMS.

It could be just a config which we can easily query e.g. (drupal_cms: true) or anything else. We potentially could also include this setting in Gin if we can't place it somewhere outside it. However other modules might benefit of a setting like this, too in the long run. We can then make sure it gets enabled on the Drupal CMS installation progress (via recipes).

I had a similar thought. We could easily set a flag in Drupal::State for that purpose. Maybe even the Drupal CMS version which was used when setting up that site.