- Issue created by @quietone
- 🇮🇳India lavanyatalwar
Hi @quietone,
I have added return comments everywhere.
Kindly check and merge. :) - 🇮🇳India lavanyatalwar
Also, @quietone, the pipeline is failing due to PHP static analysis. It states that the method setTextMode doesn't have a return type specified. Should I set its return type to void, as nothing appears to be intended to be returned?
public function setTextMode($textMode, $untilTag = NULL) { // Do nothing, we never enter text mode. }
- 🇺🇸United States smustgrave
Shouldn't be in review until the pipeline is green.
- First commit to issue fork.
- 🇮🇳India shalini_jha
I have checked the pipeline failure and identified the issue. The PHPStan baseline needed to be updated, so I have made the necessary changes to the baseline. After updating it, the pipeline failure has been resolved. I am now moving this back to the 'Needs Review' stage.
I Have mainly worked for pipeline failure.please review if anything else needs to update. - 🇮🇳India shalini_jha
I have addressed the feedback and regenerated the PHPStan baseline. Moving this to NR for review. Kindly review.
- 🇺🇸United States smustgrave
Baseline change seems out of scope since this is pure comments.
- 🇳🇿New Zealand quietone
I rebuild the baseline on 11.x and got the same changes. The problem was introduced in 🐛 Ensure run-tests.sh and PHPUnit CLI run with the same list of tests to be executed Active . That needs an issue to fix it and then this issue is postponed on that one.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
The issue doesn't completely fix the issue as described in the comment. It talks about only excluding lib/Drupal/Core, however it also excludes lib/Drupal/Component
<exclude-pattern>core/lib/Drupal/Core/*</exclude-pattern> <exclude-pattern>core/lib/Drupal/Component/*</exclude-pattern>
I think we should commit this as-is and make the followups also fix Component. So I think this looks good.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Automatically closed - issue fixed for 2 weeks with no activity.