- Issue created by @pameeela
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
The navigation icon in the css is right. The css selector is right.
There's trash_page_top hook adding the library, but apparently is not the right place?
- 🇦🇺Australia pameeela
We are on 11.1 but using Gin, so perhaps that is where the issue lies!
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Gin has "fixed" icons hard-coded/rendered into the theme-markup, which do not "update" if new icons come into play. At least from my last test of the theme and one of the reasons we hat to stop using it. We felt like this would be a too different attempt to discuss for Gin at this point.
- 🇮🇳India Tirupati_Singh
Hello there, I've also tried replicating the issue and found that the Trash icon is displayed in the navigation. However, when using the Gin theme, the icon does not appear as mentioned by @dqd in the comment #6 🐛 Add navigation icon for Trash Active . I think the issue should be reported for Gin theme rather than the Trash module. Attaching the screenshots for reference.
Thanks!
- Merge request !535Issue #3488921: Added Trash module icon in the navigation. → (Merged) created by Tirupati_Singh
- 🇮🇳India Tirupati_Singh
Hi, I've fixed the Trash icon not being shown in the navigation while using the Trash module. Please review the changes. I'm attaching screenshots of before and after fixes of the issue for reference.
Thanks!
- First commit to issue fork.
-
saschaeggi →
committed 1ff7bd5c on 8.x-3.x authored by
tirupati_singh →
Issue #3488921: Added Trash module icon in the navigation.
-
saschaeggi →
committed 1ff7bd5c on 8.x-3.x authored by
tirupati_singh →
- 🇨🇭Switzerland saschaeggi Zurich
@tirupati_singh thanks. I've adjusted the icon so it aligns with other toolbar icons, but overall the solution was great, thank you!
Closing.
-
saschaeggi →
committed b9f3943d on 4.0.x authored by
tirupati_singh →
Issue #3488921: Added Trash module icon in the navigation.
-
saschaeggi →
committed b9f3943d on 4.0.x authored by
tirupati_singh →
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
So isn't there any way for contrib modules to provide a navigation icon that works aside of having the icon in gin itself?
- 🇨🇭Switzerland saschaeggi Zurich
Once we have the icon API fully available, yes.
Automatically closed - issue fixed for 2 weeks with no activity.