Remove 2 unused class properties in tests

Looks unused for real

These appear to be unused as well.

\Drupal\Tests\user\Kernel\Views\HandlerFilterPermissionTest::$columnMap
\Drupal\KernelTests\Core\Entity\EntityCrudHookTest::$ids
\Drupal\Tests\system\Functional\System\PageTitleTest::$savedTitle
\Drupal\Tests\Core\Batch\PercentagesTest::$testCases
\Drupal\views_ui\ViewUI::$renderPreview

It seems I did not same some changes to the Issue summary

@annmarysruthy, thanks for working on the MR. To complete this we also need to update the Issue Summary with some evidence that it is safe to remove these. Even if the current tests pass we want to look at the history to make sure that some testing hasn't been lost over the years.

I have started that for the 2 variables that started this, can you add the same details for the rest? I use git blame to find when the variable was added and then use the GitLab interface to add links to the commit. This information helps the reviewers and committers.

@annmarysruthy, thanks!

I am working on adding a link to the commits.

Time for reviews.

Seems straight forward.

Searched for some of the terms and verified where they're currently used they're actually used.

Thanks @annmarysruthy that's awesome git archeaology. I updated one issue link and reviewed all of these.

I think we're good except for \Drupal\views_ui\ViewUI::$renderPreview because technically public properties are an API.

If we want to remove that we have to write something like \Drupal\Core\DependencyInjection\DeprecatedServicePropertyTrait to use a magic __get to warn the user they're accessing a deprecated property.

APIs are forever 😢

I think that should be split into it's own issue.

Thanks everyone for the work on this one so far.

I thought I commented about renderPreview.

I think we make an exception for \Drupal\views_ui\ViewUI::$renderPreview and just remove instead of deprecating it. All usages of it in core were removed in Jun 2013 before Drupal 8 was released. in this commit.

Ok I'll add a CR and commit today

Thanks, I started the changed record.

Committed to 11.x and published the change record - thanks!

Automatically closed - issue fixed for 2 weeks with no activity.