- Issue created by @ankitv18
- First commit to issue fork.
- Status changed to Needs review
8 months ago 12:47pm 16 September 2024 - 🇮🇳India sarwan_verma
Hi,
I have fixed all the PHPCS issues and created MR!28.
Please review and verify.Thanks!
- 🇩🇪Germany Anybody Porta Westfalica
Thank you very much for the cleanup! RTBC'd!
- 🇩🇪Germany Anybody Porta Westfalica
Note to the maintainer: Please first merge 📌 Write (basic) automated tests RTBC which adds the gitlab.ci! Then let's look into the results here.
- Status changed to RTBC
4 months ago 11:54pm 29 January 2025 - 🇺🇸United States droath
I wasn't able to get the MR to apply. Are you able to reroll?
- 🇩🇪Germany Anybody Porta Westfalica
@droath yes! In 📌 Write (basic) automated tests RTBC phpcs and phpstan still fail, let's see what happens here :)
- 🇨🇦Canada danrod Ottawa
I fixed the PHPCS and some PHPSTAN issues but sadly, I don't have enough time to do some work on it today, hopefully someone could continue the work and fix the remaining issues.
- Status changed to Needs work
about 1 month ago 2:47am 8 April 2025 - First commit to issue fork.
- 🇧🇷Brazil brandonlira
Hi everyone,
I Fixed the PHPCS issues and updated service usage with dependency injection. The code is ready for review.Thank you!
- 🇮🇳India ankitv18
Pipeline runs smoothly ~~~ No more warnings are there. Also, changes looks mergeable ~~ Hence moving into RTBC.
- 🇩🇪Germany Anybody Porta Westfalica
Great work! All green now, let's merge this.
-
anybody →
committed 1d7cde9f on 2.1.x authored by
sarwan_verma →
Issue #3467787 by sarwan_verma, brandonlira, anybody, danrod, ankitv18,...
-
anybody →
committed 1d7cde9f on 2.1.x authored by
sarwan_verma →
Automatically closed - issue fixed for 2 weeks with no activity.