- Issue created by @Anybody
- First commit to issue fork.
- Status changed to Needs review
4 months ago 11:52am 9 August 2024 - Status changed to Needs work
4 months ago 3:21pm 9 August 2024 - 🇮🇳India ankitv18
All the changes seems unrelated.
Objective of this ticket to have a basic functional and unit test. - 🇩🇪Germany Anybody Porta Westfalica
@annmarysruthy please move your changes into a separate phpcs / phpstan fixes issue!
- 🇩🇪Germany Grevil
Target branch is set to 2.0.x instead of 2.1.x, that's why there are all of these seemingly unrelated changes.
But even then, there is not a single test added but 2? .gitlab-ci.ymls, with one of them containing custom code. I'll simply create a new branch containing the .gitlab-ci.yml and a generic test class for basic testing.
- Status changed to Needs review
4 months ago 9:22am 13 August 2024 - Status changed to RTBC
4 months ago 9:25am 13 August 2024 - Status changed to Needs work
4 months ago 12:17pm 13 August 2024 - 🇮🇳India ankitv18
Just a minor suggestion to check for previous minor otherwise simpler and cleaner MR.
- Status changed to Needs review
4 months ago 2:11pm 13 August 2024 - Status changed to RTBC
4 months ago 2:52pm 13 August 2024 - 🇩🇪Germany Anybody Porta Westfalica
The code style issues listed at https://git.drupalcode.org/issue/entity_extra_field-3466812/-/pipelines/... should be fixed by @droath in #3468193: [2.1.x] Entity Extra Field → I think.
Once this is merged, a follow-up should be to have more advanced tests.
- 🇩🇪Germany Anybody Porta Westfalica
@droath could use the linked issues for resolution. They don't seem to have code yet.