- Issue created by @ressa
- πΊπΈUnited States greggles Denver, Colorado, USA
+1 to using a more rapidly recognized date conceptually, though i notice that dates on admin/content are a similar format to security review.
Is there a reference page on drupal.org about formatting dates?
- π©π°Denmark ressa Copenhagen
Thanks for a fast and positive reply @greggles.
Some of Drupal's date formats were actually set to use the ISO-8601 standard in 2004 ( Drupal 4.5.0 β ) by Dries, but they must have been lost somewhere along the way ...
Maybe we should update Drupal core instead, and then perhaps it will also fix Security Review's date format? It looks like it might be using a Drupal core date format:
$ grep -iR "Review results from last run" . ./templates/run_and_review.html.twig: Review results from last run {{ date }}
I have updated the Issue Summary, and moved it to Drupal core instead.
- π©π°Denmark ressa Copenhagen
And about this:
Is there a reference page on drupal.org about formatting dates?
I am not sure, but it would be great to have one, if only just stating that the date format in the ISO-8601 standard should be followed in Drupal.
- @ressa opened merge request.
- Status changed to Needs review
3 months ago 3:16pm 7 August 2024 - π©π°Denmark ressa Copenhagen
I tried updating the date formats and tests, maybe some more tests need to be updated? Let's see!
- π©π°Denmark ressa Copenhagen
Actually, ISO 8601 doesn't cover month names (jan, feb, etc.) so this is issues aim to switch to a rapidly recognizable date format, the same as drupal.org issues uses:
Created: 7 Aug 2024 at 11:24 CEST
So updating the title.
- Status changed to Needs work
3 months ago 6:27pm 7 August 2024 - πΊπΈUnited States smustgrave
Was wondering why this ticket looked familiar haha
Will agree with @greggles but MR appears to be failing a few tests.
- Status changed to Needs review
3 months ago 4:17pm 8 August 2024 - π©π°Denmark ressa Copenhagen
Yes @smustgrave, I realized that the right method was to update all the dates :-)
And by the way, let me just repeat that I am eternally grateful that you started and lead the Needs Review Queue Initiative β initiative. In my opinion, it's among the most important initiatives, together with Drupal Starshot.
- π©π°Denmark ressa Copenhagen
Adding "7th of August" in issue summary to clarify why "08/07/2024" can be opaque.
- Status changed to RTBC
3 months ago 9:29pm 8 August 2024 - πΊπΈUnited States smustgrave
I appreciate that @ressa!
I checked the MR and changes make sense. Being from the US these formats made sense to me but agree that being more international is a good move.
- π¬π§United Kingdom catch
This looks great to me and a good sign that Olivero's visitor-facing format doesn't need to change. Could probably use product manager review though so tagging for that.
- ππΊHungary GΓ‘bor Hojtsy Hungary
https://en.wikipedia.org/wiki/Wikipedia:Overview_of_date_formatting_guid... also lists this format as the first suggested although it does not seem to have hierarchy for formats. I think this is a good improvement, also this is what DrupalCon uses for their date formats. Removing product review tag as a core product manager.
- Status changed to Needs review
3 months ago 11:22am 12 August 2024 - π©π°Denmark ressa Copenhagen
Thanks for looking at this @catch and @GΓ‘bor Hojtsy.
I noticed that there is no comma in the recommended format on Wikipedia, and found few more sources with the same format. So I updated the MR, and removed the comma. I also updated the Olivero date format, which also had a few extra spaces.
- π©π°Denmark ressa Copenhagen
I have created the documentation page Date formats under "Coding standards", since I couldn't find a page dedicated to this subject ...
Perhaps someone can review it, and add it to the menu, or place it somewhere else, if it doesn't belong in that section? Thanks!
- Status changed to RTBC
3 months ago 3:14pm 12 August 2024 - π¦πΊAustralia pameeela
Big +1 from me and agree with removing the comma as done in the latest change.
- π¬π§United Kingdom catch
Committed/pushed to 11.x, thanks!
Realised after commit that we didn't have a change record here, so added a quick one.
- Status changed to Fixed
3 months ago 9:14am 13 August 2024 - π©π°Denmark ressa Copenhagen
Thanks everyone! It's impressive that this improvement went from idea to completion in less than a week, and already see it in effect in lists under "Content" and "Recent log messages", and node edit under "Last saved".
- π©π°Denmark ressa Copenhagen
I created a follow up issue π Use ISO 8601 format in Authored on field date picker Active .
- π©π°Denmark ressa Copenhagen
@greggles:
Is there a reference page on drupal.org about formatting dates?
It doesn't look like there is, so I have created #3467914: Define a standard for Date formats β .
- πΊπΈUnited States smustgrave
It's impressive that this improvement went from idea to completion in less than a week,
Amazing work!
- π§π¬Bulgaria pfrenssen Sofia
Great improvement, and impressive speed of execution! Thanks all!
- π¦πΊAustralia mstrelan
Should this have a change record or release note snippet?
- π¦πΊAustralia acbramley
This is really funny but this change broke preview_link tests https://git.drupalcode.org/project/preview_link/-/jobs/2449886
Was fun to track down, thanks to @mstrelan for letting me know about this change!
- π¬π§United Kingdom longwave UK
Added the UI changes section, don't think this needs a release note as it only affects new installs but tagged as a highlight in case we want to point it out in a blog post.
Automatically closed - issue fixed for 2 weeks with no activity.