- Issue created by @jrb
- Status changed to Needs review
about 1 month ago 8:51pm 25 July 2024 - πΊπΈUnited States jrb Raleigh-Durham Area, NC, USA
Here is a patch that adds a counter and uses that to make sure that
uniqueBundleId
is always unique.This fixes our issue with Flag and should fix the other referenced issues above.
- Status changed to Needs work
about 1 month ago 9:44pm 25 July 2024 The Needs Review Queue Bot β tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request β . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs review
about 1 month ago 12:37am 26 July 2024 - Status changed to Needs work
about 1 month ago 9:42am 26 July 2024 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Merge request !8944Issue #3463875: Add, use counter for making bundle IDs passed to loadjs unique. β (Open) created by jrb
- Status changed to Needs review
about 1 month ago 3:06pm 26 July 2024 - πΊπΈUnited States jrb Raleigh-Durham Area, NC, USA
Here's a patch from the MR.
Note that this patch is for 11.x while the patch in #2 above will apply to 10.x.
- Status changed to Needs work
about 1 month ago 6:19pm 26 July 2024 - πΊπΈUnited States smustgrave
Thanks for reporting, as a bug can we get a test case showing the issue
- π΅π±Poland michal_liszka
Despite applying patch #2 for Drupal 10, the problem persists when request the controller for a response via AJAX dialogs.
The first request executes correctly, and the response is accurate on the second attempt. However, the same error continues to occur:
An error occurred during the execution of the Ajax response: LoadJS
Code snippet:
<a href="{{ url('controller_route_name') }}" class="use-ajax" data-dialog-options="{{ dialog_options|json_encode() }}" data-dialog-type="modal" data-ajax-http-method="GET" >
- πͺπΈSpain espurnes
After updating to Drupal version 10.3.1 (I was before at version 10.2.4), the "An error occurred during the execution of the Ajax response: LoadJS" error is generated on my custom code after CTAs with ajax actions that should replace page content. Big pipe is not enabled. So it should be related with the way I perform the ajax calls (or the addition of the libraries) and the way drupal 10.3 processed them.
Applying patch #2 solves the issue.
- π³π±Netherlands Spokje
I've stumbled over this when trying to open a configuration on
/admin/config/development/configuration
more than once.
Might make it easier to reproduce in core only for testing.Patch #2 worked for me.
- Status changed to Needs review
26 days ago 5:21pm 12 August 2024 - π³π±Netherlands Spokje
MR now has a test. Tried to do this in
\Drupal\Tests\system\FunctionalJavascript\ModalRendererTest
but couldn't get the error there, maybe/probably due to the lack of JS/CSS on that page?So I decided to use a bit of
\Drupal\Tests\config\Functional\ConfigImportUITest
in a new FunctionalJavascriptTest.
Not great, not fast, but we need JS testing for this and this was the only place in core I could reproduce the error.MR passes, test-only fails where it's expected to fail.
- First commit to issue fork.
- Merge request !9184Resolve #3463875 "Bigpipe loadjs errors isdefined" β (Open) created by godotislate
Looking at the documentation for loadjs, there is a
isDefined()
method that checks for existing bundle IDs, so I think the counter might be unnecessary altogether. I created a new MR 9184 based on the original MR, and added isDefined() checks. It passes all tests, including the new one from #13.godotislate β changed the visibility of the branch 3463875-bigpipe-loadjs-errors to hidden.
- Status changed to RTBC
19 days ago 1:23pm 19 August 2024 - πΊπΈUnited States smustgrave
Believe adding the isDefined check makes sense.
- Status changed to Needs work
13 days ago 2:35am 26 August 2024 - π³πΏNew Zealand quietone New Zealand
Trying for a descriptive of what is being fixed. I also left 2 comments in the MR about documentation that need attention.
- Status changed to Needs review
13 days ago 5:45am 26 August 2024 - π³π±Netherlands Spokje
Thanks @quietone, applied your suggestion and added a comment.
- Status changed to RTBC
9 days ago 2:15pm 29 August 2024 - πΊπΈUnited States smustgrave
Believe additional feedback has been addressed.
Hoping eventually can help close resolved threads but can't help there either :(