- Issue created by @clayfreeman
- Merge request !8797Overridden view block title should be set on the view itself β (Open) created by clayfreeman
- Issue was unassigned.
- Status changed to Needs review
2 months ago 5:44pm 6 August 2024 - Status changed to RTBC
2 months ago 6:18pm 11 August 2024 - πΊπΈUnited States smustgrave
Ran test-only feature
1) Drupal\Tests\block\Functional\Views\DisplayBlockTest::testBlockRendering Failed asserting that the text of the element identified by '#test-view-block--title' equals 'Custom title'. Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'Custom title' +'test_view_block' /builds/issue/drupal-3461896/core/tests/Drupal/Tests/WebAssert.php:807 /builds/issue/drupal-3461896/core/modules/block/tests/src/Functional/Views/DisplayBlockTest.php:277 FAILURES! Tests: 6, Assertions: 101, Failures: 1.
Code wise believe this makes sense
$this->configuration['views_label']
doesn't appear to be in$output['#title'] = ['#markup' => $this->view->getTitle(), '#allowed_tags' => Xss::getHtmlTagList()];
So checking views_label probably didn't make sense. Think breaking up was the right call.
Only think I'm iffy about is the removal of getConfiguration() if that's going to require any BC dance.
otherwise LGTM.
- Status changed to Needs work
about 1 month ago 1:33pm 6 September 2024 - Status changed to RTBC
about 1 month ago 7:04pm 6 September 2024 - πΊπΈUnited States clayfreeman Paragould, AR
Since this is a test-only nit, moving back to RTBC.