- Issue created by @finnsky
- π·πΈSerbia finnsky
finnsky β changed the visibility of the branch 3460979-reduce-jquery-usage to hidden.
- Status changed to Needs review
7 months ago 11:27am 12 July 2024 - First commit to issue fork.
- Status changed to RTBC
7 months ago 2:03pm 14 July 2024 - Status changed to Needs work
7 months ago 2:20pm 26 July 2024 - π«π·France nod_ Lille
I like it, we do need to add the deprecation of the jQuery event here. And introduce a BC layer for events so that calling
$dialog.trigger('event');
triggers a deprecation and generate the custom DOM event. - Status changed to Needs review
7 months ago 9:35am 28 July 2024 - Status changed to Needs work
7 months ago 6:51pm 30 July 2024 - π·πΈSerbia finnsky
Not sure how this deprecation check work in Drupal.
I wrote Nightwatch test. But is seems still not working as it should.https://gyazo.com/825ac43bc3dea0bb303cc214a7fab597
Depreciation messages presented in console. script js aswell.
- π·πΈSerbia finnsky
That is weird. But in logs i see that test was trigered in test environment.
- Status changed to Needs review
7 months ago 8:49am 2 August 2024 - Status changed to RTBC
6 months ago 3:33pm 19 August 2024 - πΊπΈUnited States smustgrave
JS skill is mid at best.
But deprecation and test coverage looks correct to me.
Testing the changes on dialog popups on views and block_layout and everything appears to be working as before.
Going to go on a limb and say this is good.
- π«π·France nod_ Lille
Thanks, solid work, still a few things to address. Thanks for your patience!
- π·πΈSerbia finnsky
I've added one comment about jQuery selectors.
All other feedbacks are fixed. The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π·πΈSerbia finnsky
@nod_ thank you for feedbacks. i fixed everything according them.
I agree - we need to care about jquery selectors in own task and deprecate them globally at once.
please review!
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs work
3 months ago 6:16pm 18 November 2024 - πΊπΈUnited States smustgrave
Believe needs a manual rebase now, probably would update the deprecations for 11.2 now :(
- πΊπΈUnited States smustgrave
Sorry to do it but appears to need another rebase.
- πΊπΈUnited States smustgrave
Sorry slipped my radar, needs a rebase again. Please ping me so I can add to top of my list
If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
- πΊπΈUnited States smustgrave
Seems to have test failures now though, functional, javascript, and nightwatch
- π·πΈSerbia finnsky
@vladimiraus thank you for care about this issue ;)
@smustgrave here usual random failures. all green now.
- πΊπΈUnited States smustgrave
Seems to need another rebase
@finnsky or @VladimirAus feel free to self RTBC after
If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!