Reduce jQuery usage

finnsky → changed the visibility of the branch 3460979-reduce-jquery-usage to hidden.

Looks good.

I like it, we do need to add the deprecation of the jQuery event here. And introduce a BC layer for events so that calling $dialog.trigger('event'); triggers a deprecation and generate the custom DOM event.

Added BC and change record

Possible to get a deprecation test.

Not sure how this deprecation check work in Drupal.
I wrote Nightwatch test. But is seems still not working as it should.

https://gyazo.com/825ac43bc3dea0bb303cc214a7fab597

Depreciation messages presented in console. script js aswell.

That is weird. But in logs i see that test was trigered in test environment.

JS skill is mid at best.

But deprecation and test coverage looks correct to me.

Testing the changes on dialog popups on views and block_layout and everything appears to be working as before.

Going to go on a limb and say this is good.

rebased, seems ready to go

Rebased. Review needed

¯\_(ツ)_/¯

Thanks, solid work, still a few things to address. Thanks for your patience!

I've added one comment about jQuery selectors.
All other feedbacks are fixed.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

@nod_ thank you for feedbacks. i fixed everything according them.

I agree - we need to care about jquery selectors in own task and deprecate them globally at once.

please review!

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Believe needs a manual rebase now, probably would update the deprecations for 11.2 now :(

rebased and updated versions