[random test failure] jQuery Events Deprecation Tests (Tests/dialogDeprecations)

Most likely this is because we're not waiting for .ui-dialog-content to exist, we're just waiting an arbitrary 100ms. But also it takes 30 seconds for me to run the nightwatch test, compared to 6 seconds to run the same in phpunit. This is likely due to all the setup required for nightwatch that happens via the UI. For this reason I've converted to phpunit.

As a bonus we can use REPEAT_TEST_CLASS now that it's a phpunit test.

Original (100ms timeout) failed 46/100 times - https://git.drupalcode.org/issue/drupal-3521621/-/jobs/5093110/viewer
Updated (wait for element) failed 0/100 times - https://git.drupalcode.org/issue/drupal-3521621/-/jobs/5092934

So we could just apply the same fix to the nightwatch test, but I think the 5x speed boost makes phpunit worth it.

mstrelan → changed the visibility of the branch 3521621-dialog-deprecations-timeout to hidden.

Yes please, this has failed multiple times in a row on another branch.

Great idea to make this a regular functional js test.

Committed/pushed to 11.x and cherry-picked to 10.5.x, thanks!

catch → closed merge request !11967

Committed the wrong MR here, so reverted and committed the correct one...

catch → closed merge request !11966

This broke phpstan on 10.5.x, reverted. Let's recommit with a new baseline.

catch → credited quietone → .

quietone → changed the visibility of the branch 3521621-dialog-deprecations to active.

quietone → reopened merge request !11966

There are now test failures,

• core/tests/Drupal/FunctionalJavascriptTests/Dialog/DialogDeprecationsTest.php
• core/modules/big_pipe/tests/src/FunctionalJavascript/BigPipeRegressionTest.php
• core/modules/book/tests/src/Kernel/BookMultilingualTest.php

Locally, BookMultilingualTest.php fails as a result of 🐛 LanguageNegotiationUrl unnecessarily adds domain to outbound URL's Active .

Meant to add thatBookMultilingualTest.php failed in the issue, https://git.drupalcode.org/project/drupal/-/pipelines/482509/test_report.... But is not failing on 10..5 scheduled pipeline.