Dialog buttons do not inherit accessibility-related attributes

Would appreciate an expert's review to ensure the work is sufficient :)

Pipeline seems to have passed; ready for manual review now.

I've added one comment here. Probably it will help

This looks good to me. All the new attributes are copied over in the submit button when a form is loaded in a modal.

There is a comment about adding a followup issue. Is that needed? Adding tag just in case.

This is tagged for an accessibility review. That still needs to happen. I am not sure of the process but asking in #accessibility is a start.

I don't believe the follow-up is needed, or at least it shouldn't block the work being done here. I'm happy to entertain the proposed change if Drupal core is willing to take on such a task, but I doubt the likelihood of that outcome.

I'll post in #accessibility -- thanks for the suggestion.

small comment on MR

Ran test-only feature though to check test coverage

1) Drupal\FunctionalJavascriptTests\Ajax\DialogTest::testDialog
Failed asserting that false matches expected true.
/builds/issue/drupal-3460846/core/tests/Drupal/FunctionalJavascriptTests/Ajax/DialogTest.php:188
FAILURES!
Tests: 2, Assertions: 53, Failures: 1.

Which shows it

Did a manual test (very similar to the actual test)
Went to ajax-test/dialog
Clicked Link 5
Verified the "Hello world" button had no aria attributes

Went to /ajax-test/dialog-form
Verified the attributes were there

So fix does address the problem described.

Will leave in review for others and that nitpicky variable name (can mark after that).

Forgot about inline editor so made the change myself

Will try and get accessibility sign off.

Took a look at the code and it seemed reasonable. @smustgrave thanks for doing the manual testing. Would be nice to get it in.

Thanks @mgifford!

Btw. Probably we also need to discuss.
Why we not copy ALL attributes here?

If we need exact copy of original button it has sence

Let’s open a follow up for that. Getting this in as js least helps accessibility

I would like to see something better than just copy. :)

https://codepen.io/finnsky/pen/qBzGNoZ?editors=1010

Here i added example how it may work.

Looking this source code over (have not pulled a test environment) --

I would not drop aria-describedby and aria-labelledby if the targets are rendered on the page. I see your logic, but if those attributes are present for some reason, won't they be equally needed in the duplicate?

Also -- I'm assuming if there is no aria-label on the source, this code won't put that attribute on the target, as opposed to putting an empty aria-label? I've seen the latter sneak through now and then.

And last -- aria-details does not have widespread support. It doesn't hurt to copy the attribute, but developers really should not be using this attribute in production code.