I applied the change in #9 and #10 to the issue fork.
jeremyvii β made their first commit to this issueβs fork.
Ready for review. When running failing Functional tests locally, I would get an error indicating the container wasn't set properly. In order to get proper test failure messages, I made use of $this->container
and $link->getUrlObject()->toString()
.
jeremyvii β made their first commit to this issueβs fork.
I have created a kernel and Nightwatch tests for this merge request.
I rebased the merge request to fix the merge conflicts in #76 and updated the issue summary.
jeremyvii β made their first commit to this issueβs fork.
jeremyvii β created an issue.
This looks good to me. All the new attributes are copied over in the submit button when a form is loaded in a modal.
I can confirm that I am using the correct view mode. After further investigation, this appears to be happening with any field in Layout Builder. In Drupal\layout_builder\Plugin\Block\FieldBlock::blockAccess
, the selected field's isEmpty()
method is checked, and if true
, access to the block is forbidden. There appears to be an issue for the Drupal project to try to add a setting to allow the field to display, even if empty. It would be nice OfficeHoursItemList::isEmpty()
returned false
if show_empty
is checked, but I can understand how that would be messy to implement.
In order to replicate, all the hours must empty on the entity.
Without Layout Builder.
With Layout Builder
jeremyvii β created an issue.
jeremyvii β created an issue.
jeremyvii β created an issue.
jeremyvii β created an issue.
When applying the patch from #12, Image and Video Media entities worked as expected, while Audio File and Document Media entities did not. I could view Audio File and Document Media entities via the media/{view}/{id}/view
path, but I could not download these media items via media/{view}/{id}
or media/{id}
.
This patch worked. Thanks!
jeremyvii β created an issue.