- Issue created by @catch
- Status changed to Needs work
2 months ago 1:20pm 3 July 2024 - 🇬🇧United Kingdom catch
Made a start - but the change needs to be made in every copy of node.html.twig in core, of which there are a lot.
- 🇬🇧United Kingdom longwave UK
I am almost certain
readmore
can go as well, this was dropped way way back in #372743: Body and teaser as fields → but lingers on in the documentation, even though it doesn't work. - 🇬🇧United Kingdom catch
Yes let's do that one here too! Unbelievable levels of cruft.
- First commit to issue fork.
- 🇮🇳India ankitv18
Hi,
I've removed the mentioned doc variables from node--*.html.twig and node.html.twig from the respective profile, themes and modulesMR!8648 still in draft state @catch could move MR into review.
- Status changed to Needs review
2 months ago 7:13am 6 July 2024 - Status changed to Needs work
about 2 months ago 1:33pm 10 July 2024 - Status changed to Needs review
about 2 months ago 1:41pm 10 July 2024 - 🇬🇧United Kingdom longwave UK
In my opinion no change record is required, this is a documentation improvement/fix only.
- Status changed to RTBC
about 2 months ago 1:43pm 10 July 2024 - 🇬🇧United Kingdom longwave UK
No further instances remain, to me this is RTBC. As a docs only fix I think this can be backported to 10.3.x if we want to.
- 🇺🇸United States smustgrave
But there are tons of node.html.twig templates in themes out there. If you use the CR system to figure out when to update your theme templates this will be missed.
- 🇬🇧United Kingdom catch
@smustgrave but nothing in the actual twig template content needs to change, if people copy the entire docblock from core that is up to them. We don't add CRs for any other documentation changes, but people do copy and paste those around too.
- 🇬🇧United Kingdom longwave UK
Fair enough, we don't often write change notices just for themers, but here's an attempt for this one: https://www.drupal.org/node/3460562 →
- 🇺🇸United States smustgrave
I know for a theme I have I started with the templates from the starterkit theme using the generator.
Thanks @longwave!
- Status changed to Fixed
about 2 months ago 7:35am 17 July 2024 - 🇫🇷France nod_ Lille
Committed and pushed 86138d4c11 to 11.x and 98f8509200 to 11.0.x and 1f4aa5cf19 to 10.4.x and 873b1e7b07 to 10.3.x. Thanks!
- 🇩🇰Denmark ressa Copenhagen
Thanks for the clean up everyone. Template variables that do nothing are among the thousand paper cuts, which seem innocent enough, but they all add up.
And thanks for suggesting and creating a Change Record @smustgrave and @longwave, which is how I heard about this improvement.
I manually open the Change Record → page daily, to see if anything exciting has happened in Drupal. If only we could subscribe to Change Records ... maybe some day it will happen? ✨ Allow email subscriptions to Change records Active
Automatically closed - issue fixed for 2 weeks with no activity.