Contrib.social

Review from Nat

Open on Drupal.org →
Created on 20 June 2024, 5 months ago
Updated 6 August 2024, 3 months ago


2. Nit: sometimes uses the bundle name, sometimes the bundle class https://git.drupalcode.org/project/lms/-/blob/1.0.x/lms.module?ref_type=...

4. https://git.drupalcode.org/project/lms/-/blob/1.0.x/lms.module?ref_type=... we should move this to a computed field.
📌 Add a computed field for the course action element Active
5. https://git.drupalcode.org/project/lms/-/blob/1.0.x/lms.module?ref_type=... we could potentially end up with a cascade issue if there's a lot of module statuses and answers when a training is deleted - should we queue the module statuses and or answer deletion? 📌 Add a queue for course/lesson status deletion Active
6. Have a feeling we can lose this, or close to being able to lose it, now that classes change is merged? https://git.drupalcode.org/project/lms/-/blob/1.0.x/lms.views.inc?ref_ty...
7. Could learning-path-action-info.html.twig be #type container with a theme suggestion instead of its own theme hook? 📌 Use #type container with a theme suggestion for 'lms_course_action_info' Active
8.lms-lp-step-activity.html.twig this could potentially use #theme item_list with a theme suggestion? 📌 Use #item_list instead of a custom template for lms-lp-step-activity.html.twig Active
9. https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Attribute/Activi... very nice to see attributes!!

11. https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Controller/Train... should we have a 📌 Investigate dropping the redirect usage in TrainingController start Active
12. Minor/todo, wonder if we can do this on answer submission (first answer in a new module) instead of in the controller https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Controller/Train... 📌 Move status saving out of TrainingController if possible Active


14. https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Entity/Handlers/... is this really required or can we just skip it in favour of views?

15. https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Entity/Handlers/... should this also check a 'view own answers' permission and also group permissions so that group admins can see answers?
📌 AnswerAccessControlHandler should check more permissions Active

16. https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Entity/Handlers/... does this permission exist and would we ever let students see this? I think it can be dropped. Same for https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Entity/Handlers/... - no need to manually create these ever. 📌 Consider removing LessonStatusAccessControlHandler Active

17. https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Entity/Activity.... this entity type has a publshed/status field but doesn't extend EditorialContentEntityBase or equivalent interface - I think we could drop the status field since it is only ever going to be learning path content or not?
🐛 Clarify published status on activities Active .

18. https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Entity/Answer.ph... we should have a @todo to use json instead.

19. Bit confused what this is doing - why do activity types get installed? https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Form/ActivityTyp...
📌 What does 'installed' mean for activity types Active

20. https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Plugin/ActivityA... be nice if the positives/negatives lined up here.
📌 Clean up evaluatedOnSave() vs needsManualEvaluation Active

21. https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Plugin/ActivityA... should this return the actual score or why is the score returned here at all?

📌 LongAnswer::getScore() always returns 1 Active

22. Maybe we can drop this now classes are mandatory? https://git.drupalcode.org/project/lms/-/blob/1.0.x/src/Plugin/views/arg...

📌 Check if views plugins are still necessary. Active

📌 Task
Status

Closed: duplicate

Version

1.0

Component

Other backend

Created by

🇵🇱Poland Graber

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024