clean-up outdated mentions of prepareLegacyRequest

Created on 7 June 2024, 21 days ago

Problem/Motivation

The method \Drupal\Core\DrupalKernel::prepareLegacyRequest() was deprecated and removed from codebase in πŸ“Œ Remove usages of deprecated DrupalKernel::prepareLegacyRequest() Fixed
But there's still mentions and probably functionality related to it
Moreover there's mentions of bootCode() in the same comment

Steps to reproduce

$ git grep -A2 -B2 prepareLegacyRequest
core/includes/install.core.inc-507-
core/includes/install.core.inc-508-  // Initialize a route on this legacy request similar to
core/includes/install.core.inc:509:  // \Drupal\Core\DrupalKernel::prepareLegacyRequest() since normal routing
core/includes/install.core.inc-510-  // will not happen.
core/includes/install.core.inc-511-  $request->attributes->set(RouteObjectInterface::ROUTE_OBJECT, new Route('<none>'));
--
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php-524-    // Explicitly call register() again on the container registered in \Drupal.
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php-525-    // @todo This should already be called through
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:526:    //   DrupalKernel::prepareLegacyRequest() -> DrupalKernel::boot() but that
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php-527-    //   appears to be calling a different container.
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php-528-    $this->container->get('stream_wrapper_manager')->register();
--
core/tests/Drupal/Tests/BrowserTestBase.php-564-    // Explicitly call register() again on the container registered in \Drupal.
core/tests/Drupal/Tests/BrowserTestBase.php-565-    // @todo This should already be called through
core/tests/Drupal/Tests/BrowserTestBase.php:566:    //   DrupalKernel::prepareLegacyRequest() -> DrupalKernel::boot() but that
core/tests/Drupal/Tests/BrowserTestBase.php-567-    //   appears to be calling a different container.
core/tests/Drupal/Tests/BrowserTestBase.php-568-    $this->container->get('stream_wrapper_manager')->register();
$ git grep -A3 -B3 bootCode
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php-516-    // Reset/rebuild all data structures after enabling the modules, primarily
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php-517-    // to synchronize all data structures and caches between the test runner and
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php-518-    // the child site.
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:519:    // @see \Drupal\Core\DrupalKernel::bootCode()
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php-520-    // @todo Test-specific setUp() methods may set up further fixtures; find a
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php-521-    //   way to execute this after setUp() is done, or to eliminate it entirely.
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php-522-    $this->resetAll();

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component
BaseΒ  β†’

Last updated less than a minute ago

Created by

πŸ‡«πŸ‡·France andypost

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024