Drupal views: adding more granularity to the ‘use ajax’ functionality

In order to be able to separate the operation from the activation of AJAX on my view, I propose the following patch

patch #1 →

In order to be able to separate the operation from the activation of AJAX on my view, I propose the following patch
patch #1 →

In order to be able to separate the operation from the activation of AJAX on my view, I propose the following patch

patch #1 →

In order to be able to separate the operation from the activation of AJAX on my view, I propose the following patch.

patch #1 →

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Prashant.c → made their first commit to this issue’s fork.

Prashant.c → changed the visibility of the branch 3450525-views-ajax-options to hidden.

@jschneidertcs

This would be a really helpful feature to have. Thanks for raising this.

Raised the MR based on the patch submitted in #3 ✨ Drupal views: adding more granularity to the ‘use ajax’ functionality Needs work

Did a little code refactoring and rephrasing of the labels.

Found a bug that needs work, when the "use AJAX" option is enabled and none of the options are checked it should apply AJAX on all the components (pager, filter criteria, sort criteria) which is the existing default behavior.

Thanks!

One other bug
https://www.awesomescreenshot.com/video/28387328?key=2463ee3fc3137a32957...

When I uncheck the main "use AJAX" checkbox the 3 options on which AJAX will get applied should also get unchecked which is not happening.

jschneidertcs → closed merge request !8376

jschneidertcs → closed merge request !8377

jschneidertcs → reopened merge request !8377

julien_g → changed the visibility of the branch 3450525--views-separate-ajax-options to hidden.

@prashantc

I've updated the bug you added in your comment.

The pull request has passed all the pipeline steps and is now ready to be validated.

P.S. : I would remind you that the page sorting part is still missing. I haven't managed to define where to take this parameter into account. If you tell me where to make the changes, I'll be happy to do it.

@jschneidertcs

Thanks for making the effort to resolve the previously reported issues.

Regarding the "Sorting" ajax enable/disable it looks like it is from the same file core/modules/views/js/ajax_view.js but it is somewhere conflicting with the use_ajax_paging or ajax-pager because I noticed when the AJAX on sorting criteria getting enabled/disabled based on the enable/disable on pager. If you keep the pager AJAX disabled then sorting AJAX is also disabled and same for enable.

Hope this helps.

@prashantc

Thanks for your help. I've updated the file for the sorting part and now it should be ok.

IMO tests will also be required for this, therefore tagging for tests as well.

What are the next steps ? Do I need to make something else ?