CategoryAutocompleteController should check that user actually provided query string

I have navigated to above url but dont see any issue

I do not see any errors in /block-category/autocomplete page (Screenshot attached)

@chanduvkp check out dblog after visiting that page.

Able to replicate the issue. Getting the below error while accessing the /block-category/autocomplete.

Before applying the patch:

But, after applying patch DB log gone. But the filter with q argument is only working. Empty filter not giving any result.
Empty Query string

With Query string

Updated the MR by,

     $matches = [];
     foreach ($this->blockManager->getCategories() as $category) {
-      if ($typed_category && stripos($category, $typed_category) === 0) {
-        $matches[] = ['value' => $category, 'label' => Html::escape($category)];
+      $matches[] = ['value' => $category, 'label' => Html::escape($category)];
+      if ($typed_category && stripos($category, $typed_category) !== 0) {
+        array_pop($matches);
       }
     }

Hello,
The deprecated issue has been fixed. I have created a patch for it. Please review.
Thank you!

MR seems to be full of out of scope changes.

We now have two different possible approaches, one in a merge request and one in a patch file. In general, we need to use MRs from now on because patches will no longer work with automated testing. Without doing more research, I'm also not totally sure that either approach is quite right here, so untagging as novice for now. Thanks!

The MR was apparently made for some other issue.

Re #9.
No need to check user input for each block category inside the loop. I think we could just wrap the entire loop into if statement.

if ($typed_category) {
  foreach ($this->blockManager->getCategories() as $category) {
    if (stripos($category, $typed_category) === 0) {
      $matches[] = ['value' => $category, 'label' => Html::escape($category)];
    }
  }
}

Hi,

Please review MR - https://git.drupalcode.org/project/drupal/-/merge_requests/8470

Thanks!!

#10 points still apply. Believe this is just turning #9 into an MR.

Hi @smustgrave,

MR is updated.

MR Link : https://git.drupalcode.org/project/drupal/-/merge_requests/8470

Thank you!!

No I mean summary needs to be updated and a test added

Hi smustgrave,

Please find updated MR : https://git.drupalcode.org/project/drupal/-/merge_requests/8470

Thank You!!

Issue summary is still incomplete

Ran the test-only feature and they passed when it should of failed to show the coverage, so leaving tag for that.

Fixes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

Prashant.c → changed the visibility of the branch 3445415-categoryautocompletecontroller-should-check to hidden.

1. Test the changes from https://git.drupalcode.org/issue/drupal-3445415/-/tree/3445415-categoryautocompletecontroller-should-check-1 working fine, no more throwing warnings.
2. Update the issue summary
3. Tests are also written and passing
4. Making the MR https://git.drupalcode.org/issue/drupal-3445415/-/tree/3445415-categoryautocompletecontroller-should-checkhidden.
5. Rebased the branch
6. Removing issue tags Needs issue summary update, Needs tests, feel free to re-add in case something is missing.
7. Moving to Needs review state

Re-adding the "Needs tests" tag as per https://www.drupal.org/project/drupal/issues/3445415#comment-15655227 🐛 CategoryAutocompleteController should check that user actually provided query string Needs review