Navigation LayoutBuilder UI has dead click zone

maybe both these are related to offset use.

This fix breaks collapsed sidebar expand popover functional.

Thank you for the feedback @finnsky, I have updated the MR with different approach.

The changes are working fine. Attaching screen capture

Hi
I've tested MR!8038 on Drupal 11.x
MR is applied cleanly...

On the Navigation LayoutBuilder, Link is added and it's working.

Adding Screen recording for reference

RTBC+1

Keeping in "Needs review" for code verification

finnsky → changed the visibility of the branch 3444699-navigation-layoutbuilder-ui to hidden.

finnsky → changed the visibility of the branch 3444699-navigation-layoutbuilder-ui to active.

Looking good to me +1 rtbc. I've added 2 small improvements.

1. Added type=submit to expand/close buttons to avoid LB form submit.
2. Added minor css fixes. Font size for LB text and always wide sidebar in css.

The lower 'narrow/expand' button is now locked open if user click. the left side of the page content remains fixed left (remains partially hidden under the entire nav.

Made changes to the MR. Attached screen capture for ref.

Hi
I've tested MR!8038 on Drupal 11.x
MR is applied cleanly...

Left sidebar button is clickable and Content page hiding issue fixed
Adding Screen recording for reference

RTBC+1

Keeping in "Needs review" for code verification

Steps forward!
I'm still finding some general switching it from narrow and back and forth again the overhand is reoccurring.

I restested to see the issue mentioned in #18 but was not able to reproduce the same. Attaching screen capture for reference

@ahsannazir thanks!
I have also retested this morning and can not recreate what I had seen. I think I had a local cache problem from branch changes. I'll move to RTBC.

Thanks for the fix, let's keep the scope to what the issue is about though.

Can you roll back the button and font size fixes and create new issues? The git history will be useless if we sneak in out of scope fixes.

thx, minor whitespace to fix and we should be good to go

Gauravvvv → changed the visibility of the branch 3444699-navigation-layoutbuilder-ui to hidden.

Gauravvvv → changed the visibility of the branch 3444699-navigation-layoutbuilder-ui to active.

Whitefix has been added, This is ready to go

all good now

nod_ → closed merge request !8038

Committed and pushed d488327312 to 11.x and 43e4c0c9c6 to 11.0.x and 83e91f4dcb to 10.4.x and 2aa3efe0d9 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.