Mobile version of Navigation menu doesn't properly reset Drupal.displace() on closing

I think we can do it simpler here.

`admin-toolbar__displace-placeholder` should be responsive probably.

Yes.
Seems it was not about transitions but about default value of `admin-toolbar__displace-placeholder` which was 72px as for collapsed desktop sidebar.
CSS works here. Please review.

Tested the MR, Working fine. Please find the attached screenshot for reference.

Before patch apply

After patch apply

mherchel → changed the visibility of the branch 3443576-mobile-version-of to hidden.

+1 RTBC. Not setting the width of the element that displace monitors until it's at the appropriate width makes sense. Good solution!

I'm not sure this is the right fix. I can still get the menu icon offset with the patch on the desktop resolution with the menu collapsed. it does fix the mobile use case but I think we need to fix it once for all the use cases.

I think the root of the issue is this rule:

body.is-fixed .container {
  width: calc(100% - var(--drupal-displace-offset-left, 0px) - var(--drupal-displace-offset-right, 0px));
}

This doesn't seem to work like expected. this would make sense for absolute/fixed positioned elements, but .containers are not, from what I can see they're managed with flexbox, so we don't need to account for anything special.

There is another issue with displace, there is a 9px offset on top, when there should be none.

umm maybe that needs to be a follow-up issue

finnsky → changed the visibility of the branch 3443576-css-only to hidden.

finnsky → changed the visibility of the branch 3443576-css-only to active.

finnsky → closed merge request !7958

finnsky → reopened merge request !7958

I got what you mean, but it is out of scope of navigation module. even more. this is not new problem

problem now:

problem before:

So i suggest to open Olivero ticket for this.

Tagging for follow up in #18

Can issue summary be updated to include proposed solution

Follow up issue created.

Thanks all feedback appears to be addressed.

nod_ → closed merge request !7958

Committed and pushed 9a6641dea3 to 11.x and 83ea1d22bf to 11.0.x and 6e78beed9e to 10.4.x and 80b88cf280 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.