Remove deprecated code from lib/State and lib/Session

Looks good on lib/Session. It does not yet include lib/State. I think we should only remove the defined array element in lib/State and keep the infrastructure as-is. (That said the key does not say there it is deprecated for 11, so we need to verify that).

Yup missed that one because drupal:11 was excluded

The CR points to https://www.drupal.org/node/3358337 → so believe most of the deprecation for this has actually been removed already. So think this is just more cleanup.

Looking at 📌 Deprecate _drupal_flush_css_js() and create a new AssetQueryString cache service Fixed Every other bit around deprecating _drupal_flush_css_js was set to be deprecated in 11.x. I'm guessing because of the odd way of storing the deprecation message here, Our normal way of detecting the bad deprecation message format didn't notice that we forgot it in that string. I think it's good to remove in 11.x

Committed d494e66 and pushed to 11.x. Thanks!

This also removed the deprecation infrastructure in state. Do we believe that is not needed anymore? I proposed above to only remove the array key which defined the once key that was deprecated not the whole method of deprecating state.

Gábor's right - we should leave that in, otherwise we'll have to add it back again next time we want to deprecate a state key, and we have issues open for that already I think that will need it. Reverted for now, just needs to remove slightly less.

My fault, I misunderstood what was being referred to in #6

Should we add back the legacy state test and set a faux deprecation via reflection to test the infrastructure?

I think its fine that there is not a meta-test, the newly deprecated state keys will test the infrastructure too again.

Another promoted property that doesn't need promoting.

Fixed

Believe this one is good again.

Committed 14a0a6d and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.