Remove deprecations related to site settings

Created on 24 April 2024, 8 months ago
Updated 18 May 2024, 7 months ago

Problem/Motivation

Missed a schema deprecation in system module
Missed some settings.php deprecations

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Fixed

Version

11.0 πŸ”₯

Component
BaseΒ  β†’

Last updated about 3 hours ago

Created by

πŸ‡ΊπŸ‡ΈUnited States smustgrave

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @smustgrave
  • πŸ‡«πŸ‡·France andypost

    composer/Plugin/Scaffold/Operations/ScaffoldFileCollection.php:157: is deprecated for 10.x \Drupal\Composer\Plugin\Scaffold\Operations\ScaffoldFileCollection::process()

  • Status changed to Closed: outdated 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    So did one more look in modules and everything flags for removal in 11 appears to be gone. Can reopen if we find another.

  • Pipeline finished with Canceled
    8 months ago
    Total: 337s
    #160856
  • Status changed to Needs work 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave
  • Pipeline finished with Failed
    8 months ago
    Total: 661s
    #160864
  • Pipeline finished with Canceled
    8 months ago
    Total: 492s
    #160894
  • Pipeline finished with Failed
    8 months ago
    Total: 582s
    #160901
  • Pipeline finished with Success
    8 months ago
    Total: 569s
    #160922
  • Status changed to Needs review 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Tests are green but not sure about this solution.

  • Status changed to RTBC 8 months ago
  • πŸ‡«πŸ‡·France andypost

    I can't find any remaining in modules

    • xjm β†’ committed f676c3c3 on 11.x
      Issue #3443208 by smustgrave, andypost: Remove any missed deprecation...
  • Status changed to Fixed 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States xjm

    For future reference, "Remove deprecated site settings" is a good issue scope since it requires a different kind of research than most other removals. The removal from System is also related because it's about converting system configuration to settings.php.

    I confirmed that there are no remaining references to block_interest_cohort or yaml_parser_class

    Nice work on updating the test to use an 11.x example.

    Committed to 11.x. Thanks everyone!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024