- Issue created by @smustgrave
- Assigned to smustgrave
- Merge request !7697Issue #3443198: Remove deprecated code from phpPass + bigpipe β (Open) created by smustgrave
- Status changed to Needs work
7 months ago 2:21pm 24 April 2024 - πΊπΈUnited States smustgrave
Not sure what's going on with that migration test.
- First commit to issue fork.
- Status changed to Needs review
7 months ago 4:33pm 24 April 2024 - π«π·France andypost
Removal of
PhpassHashedPasswordBase::countLog2
and related needs review for BC as it was not deprecated in the base class - Status changed to RTBC
7 months ago 5:05pm 24 April 2024 - πΊπΈUnited States smustgrave
Tests are green but also donβt know the policy around protected functions.
- Status changed to Needs review
7 months ago 5:24pm 24 April 2024 - π¬π§United Kingdom catch
We should add an MR to deprecate those things in 10.3 here I think, then we can commit the deprecation and removal in one go - they're just leftovers so it won't make sense to use them with the other changes happening here, but better to keep things in sync.
- Status changed to RTBC
7 months ago 5:32pm 24 April 2024 - πΊπΈUnited States smustgrave
Added simple CR and 10.3.x branch that deprecates that function.
- Status changed to Needs review
7 months ago 5:39pm 24 April 2024 - π¬π§United Kingdom catch
It probably needs deprecated property trait for the deprecated properties too?
- Status changed to Needs work
7 months ago 6:27pm 24 April 2024 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs review
7 months ago 6:31pm 24 April 2024 - πΊπΈUnited States smustgrave
Think the bot is confused because I got a 10.3 MR up also
- Status changed to RTBC
7 months ago 6:48pm 24 April 2024 - πΊπΈUnited States smustgrave
Self review but looking at others believe got this right
Failure appears to be related to π Can't log out on translated site in tests - causes issues for 10.3 umami test Fixed
- Status changed to Needs review
7 months ago 7:07pm 24 April 2024 - π«π·France andypost
Removed unrelated file and the property is not a service, so properly deprecated it
- Status changed to RTBC
7 months ago 8:03pm 24 April 2024 - πΊπΈUnited States smustgrave
Based on the slack thread believe this one is good to go.
- Status changed to Fixed
7 months ago 8:12pm 24 April 2024 - π¬π§United Kingdom catch
Looks good now. Committed/pushed to 11.x and 10.3.x respectively, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.