Fix Drupal.Functions.MultiLineFunctionDeclaration coding standard

Checked against the meta issue, seems nothing is related/adjecent.

After running locally, there are quite a few issues in core regarding this coding standard.

Ran with:

gitlab-ci-local --variable CI_PIPELINE_SOURCE=merge_event "<0001f9f9> PHP Coding standards (PHPCS)" --variable COMPOSER_ROOT_VERSION=10.3.x-dev --needs

Most can be automaticly fixed it seems.

Added extra ignore to DrupalKernel because that had a different failure after update.

Fixed all issues automaticly, yay. Cleaning up a lot of code.

Thanks, MR looks good for 10.3.x, we will also need another MR to apply against 11.x.

Yay indeed!

Making the title the same style as other coding standard issues in the core queue. And switching the parent and related.

Also DemoUmamiProfileTest has failed twice, I thought it was random so I re-ran the job but it failed again.

Opened MR for 11.x.

The drupal 11 MR looks good and is all green. I'll see if I can find out what is failing in 10.3

There is no reason afaik that that test should fail. Rebased, trying again. Also looked if perhaps php version was an issue, but nothing notable... Arg.

Seems there are more failures on that test in other places. Suspecting its a HEAD issue in 10.3.x

The core issue has been fixed. Mr for 10.3 should pass again.

https://www.drupal.org/project/drupal/issues/3443248 🐛 Can't log out on translated site in tests - causes issues for 10.3 umami test Fixed

🐛 Can't log out on translated site in tests - causes issues for 10.3 umami test Fixed was committed so probably just needs a rebase.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased and fixed 2 remaining (new) issues in 11.x

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Bot is lying. It applies.

MR 7693 appears to need manual rebase.

pradhumanjain2311 → made their first commit to this issue’s fork.

Updated new code to standard again and fixed a conflict with 11.x

Yay, this is really nice cleanup, let's land this before the betas.

catch → closed merge request !7688

Looks great. Might be the quickest we've been compliant with a coding standard after it's agreed? Committed/pushed to 11.x/11.0.x/10.4.x/10.3.x respectively.

catch → closed merge request !7693

Thanks catch. And maybe it is ;)

Automatically closed - issue fixed for 2 weeks with no activity.

In reviewing my current codebase, I can't seem to get drupal/coder 8.3.24 due to the following dependency chain:

• drush/drush requires chi-teck/drupal-code-generator:^3.0, which installs v3.2 (at the time of this writing)
• chi-teck/drupal-code-generator 3.2 requires drupal/coder:3.2.23

I have Drush 12.5.2 installed which, at the time of this writing, is the latest version. I'm currently running Drupal 10.3.

Can somebody advise me on how to update? Alternatively I could update my phpcs.dist.xml file to reference globally installed drupal/coder sniffs as well, where I have 8.3.24 installed. However, that doesn't seem like the best approach and is less portable if other devs working on the same project don't also have the sniffs installed globally in the same location as me.

We don't release-notes-ify CS rules anymore unless they're functionally disruptive somehow (e.g. requiring typehints or whatnot). Thanks!