- Issue created by @klausi
- Status changed to Needs review
2 months ago 5:23pm 19 April 2024 - π¦πΉAustria klausi π¦πΉ Vienna
pull request: https://github.com/pfrenssen/coder/pull/225
- π¦πΉAustria klausi π¦πΉ Vienna
Found a better solution by forking our own function declaration multi-line sniff in https://github.com/pfrenssen/coder/pull/226
-
klausi β
authored ad1de270 on 8.3.x
feat(MultiLineFunctionDeclaration): Add new sniff for multi-line...
-
klausi β
authored ad1de270 on 8.3.x
- Status changed to Fixed
2 months ago 5:41pm 20 April 2024 -
klausi β
authored 1a59890f on 8.3.x
chore(composer): Bump minimum version of PHPCS (#3440603)
-
klausi β
authored 1a59890f on 8.3.x
Automatically closed - issue fixed for 2 weeks with no activity.
- π¦πΊAustralia dpi Perth, Australia
Why a custom sniff over
SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration
? - π¦πΉAustria klausi π¦πΉ Vienna
Hm, I probably did not find that sniff. Good to know that it exists, but with the fork of the upstream PHPCS sniff we cover all our requirements for Drupal, so I think it is fine.
- π¦πΊAustralia dpi Perth, Australia
Just a note that if one uses the slevomat version also, multiple errors are reported on a line. One for each rule.