Deprecation in Number::alphadecimalToInt()

pradhumanjain2311 → made their first commit to this issue’s fork.

Sandeep Sanwale → made their first commit to this issue’s fork.

Here i have added the check which validates that if $string contains malformed string then it throws an exception .

Gaurav Gupta → made their first commit to this issue’s fork.

Many tests were failing because they were passing NULL or an empty string to Number::alphadecimalToInt(). So I believe we should continue accepting these two special "degenerate" values as input. Two tests have been added: one to ensure this behavior and other to verify that an exception is thrown for any other non-alphanumeric characters.

I'm not sure how to proceed if we want to provide a deprecation message. Perhaps something like this?

@trigger_error('Passing non-alphanumeric characters is deprecated in Number::alphadecimalToInt() and will be removed in Drupal 12.', E_USER_DEPRECATED);

So believe we should actually do a deprecation here. #10 close but there's a specific pattern that has to be followed, would check core for examples. But deprecated in 11.2 and required in 12.

I've created a change record and triggered a deprecation error, as it must be done according to https://www.drupal.org/node/2856615 →

Additionally, the follow-issue 📌 Remove NumberTest::testAlphadecimalToIntReturnsZeroWithNullAndEmptyString() test Active as been created in order to remove the BC test.

Would be deprecated in 11.2

Can't add deprecation for versions with releases out already.

Oops, sorry! :) I wasn’t sure which version to include in the message since I don’t really know when this MR will be merged. I initially put 11.0.0 and later forgot to revisit it.

So, should we always deprecate for the next minor version as an estimate?

Believe feedback has been addressed.

Test covers the new exception, deprecation message for both '' and null.
CR reads fine to me, added versions to it.

LGTM

Committed/pushed to 11.x, thanks!

catch → closed merge request !7843

Automatically closed - issue fixed for 2 weeks with no activity.