- Issue created by @adarshv
- Assigned to Diksha Singhal
Hi @Aakansha Tyagi
I have created MR for the above issue.
Please review once.
Thank you- Status changed to Needs review
2 months ago 1:05pm 23 April 2024 - Status changed to Needs work
2 months ago 5:49am 24 April 2024 - 🇮🇳India ravi kant Jaipur
@Diksha@lnwebworks
Changes need to be in SASS file but there are not package.json and any automation tool to compile sass.
So I have created new ticket https://www.drupal.org/project/school_theme/issues/3443060 📌 package.json and automation tools(gulpjs) are not in theme. Active - Assigned to Tirupati_Singh
- 🇮🇳India Tirupati_Singh
Hi @Diksha@lnwebworks, it seems that you've created a new branch with the same name as the main branch i.e., 1.0.x which is also tracking the main branch, and all the changes will be directly pushed to the main branch. It's not recommended, so I'm creating a new branch with all the changes present on your commit along the new changes required for scss file.
- Issue was unassigned.
- Status changed to Needs review
1 day ago 2:01pm 24 June 2024 Hi, Applied MR 37 Now the linkedin and youtube icons are visible. Attaching the screenshot.