Linkedin and YouTube icons are not visible in footer

Hi @Aakansha Tyagi
I have created MR for the above issue.
Please review once.
Thank you

@Diksha@lnwebworks
Changes need to be in SASS file but there are not package.json and any automation tool to compile sass.
So I have created new ticket https://www.drupal.org/project/school_theme/issues/3443060 📌 package.json and automation tools(gulpjs) are not in theme. Active

Hi @Diksha@lnwebworks, it seems that you've created a new branch with the same name as the main branch i.e., 1.0.x which is also tracking the main branch, and all the changes will be directly pushed to the main branch. It's not recommended, so I'm creating a new branch with all the changes present on your commit along the new changes required for scss file.

Hi, Applied MR 37 Now the linkedin and youtube icons are visible. Attaching the screenshot.

Hi
I have tried to Install Theme Version 3.0.0 on Drupal 10 with Classy theme, But the site is throwing an expected error and unable to reproduce the issue.

Attaching SS

Hi
I have followed the below steps:

1. Installed the theme(version 3.0.0) along with classy.
2. Encountered drupal_get_path() function not found as mentioned by @Kanchan Bhogade in comment #12. Resolved the issues by applying the patch for this issue https://www.drupal.org/project/school_theme/issues/3437946 🐛 drupal_get_path() is deprecated in Drupal 9.3.0 and removed from Drupal 10.0.0 RTBC . Proceeded with the next step that is check the option to show social icons in footer and while saving the configuration encountered an error call_user_func_array(): Argument #1 ($callback) must be a valid callback. See the below ss
   
   If this step is skipped then the linkedin and youtube icon appears in the footer section but the icons are not clickable.

Added the before and after ss.
Found the footer icons related issue has been addressed in this issue https://www.drupal.org/project/school_theme/issues/3442774 📌 Preprocess is not set for footer icons. Needs review .
We can resolve the footer icon clickable and the configuration saving issue in this MR as the icon visibility is already fixed here.

Hi @esha_kundu, I've fixed the issue encountered while using the theme: all_user_func_array(): Argument #1 ($callback) must be a valid callback. Now the Social media URLs configuration field is working fine and getting no errors while saving the configuration and also the social media icons are clickable now. I've attached the screenshots for reference.

Hello,
I've reviewed the changes in the MR!37 and it looks good to me. The MR!37 applied cleanly. For the UI, I applied the patch and reinstalled the theme as there are changes in the installation configuration. Now there is no errors in the theme setting page, successfully saving the configuration changes. The clickable issue for the icons in the footer is also working.
Adding ss for reference below,
1. The configurations saves successfully.

2. when the checked the show social icons checkbox. It is clickable with default social links.

Moving to RTBC.
Thanks